Labels are 64bit but JS bindings were limited to 32bit #43
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
asilvas
commented
Sep 24, 2023
| * @return {number} number of IDs removed. | ||
| */ | ||
| removeIds(ids: number[]): number | ||
| removeIds(ids: BigInt[]): number |
There was a problem hiding this comment.
This function was already implemented correctly but had invalid type notation.
|
Let me know if you prefer these small PR's or one bigger one. Have quite a few improvements planned. |
Thank you very much for your series of improvements. Small PR's are preferred |
|
@asilvas Thank you for this pr, but considering the following points, I would like to put this pr aside. Maybe we can provide another API to deal with 64bit issues in the future.
|
|
If you're not interested in serious improvements you can close my PR's and I'll move to fork. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
An important change for large indexes, and precursor to supporting vector identifiers where index is insufficient. Faiss already natively uses 64bit labels, this PR just prevents the conversion loss.