[libudev] 1.0.3.r5.bbeb7ad-3: scan all network interfaces #4128
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For now libudev-zero only scans device nodes under /sys/dev which never contain any network device. This behaviour would cause NetworkManger refuse to manage any device and show an "unmanaged" state, since it would think that no device had been initialized yet after calling udev_enumerate_scan_devices(), with an "initialized" filter set by udev_enumerate_add_match_is_initialized() [1]. Given the daemonless design, it's tricky for libudev-zero to remember whether a device is initialized, so the workaround is to add the path "/sys/class/net" to the scan list, for now. Notice that this patch has the same effect as setting PLATFORM_INIT to true in nm-device.c [2], so it actually doesn't make everything right. Luckily, after ethtool is engaged in udev helper script [3], the settle script in eweOS would not conflict with NetworkManager, more specifically the random macaddr feature [4]. [1]: https://github.com/NetworkManager/NetworkManager/blob/dd7252ff0c98fa1eed5c0e5a7b9ebcb63aef93a2/src/libnm-platform/nm-linux-platform.c#L12171 [2]: illiliti/libudev-zero#72 [3]: eweOS#2995 [4]: https://github.com/NetworkManager/NetworkManager/blob/dd7252ff0c98fa1eed5c0e5a7b9ebcb63aef93a2/man/NetworkManager.conf.xml#L1374
![eweos-helper[bot]](https://avatars.githubusercontent.com/in/337143?s=60&v=4){kind=small}
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It makes NetworkManager think all network interfaces are ready, and will manage all of them instead of showing "unmanaged" states.
After this PR, the patch force-platform-init.patch 1 2 may no longer needed.
PS: It's still recommended to install "ethtool" (to avoid conflicts 3).