Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to jdk17.0.12+7 #189

Merged
merged 2 commits into from
Oct 8, 2024
Merged

Update to jdk17.0.12+7 #189

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b76e051
Update Dockerfile
oysvendsen Aug 28, 2024
796d42d
Update Dockerfile
oysvendsen Sep 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
FROM quay.io/evryfs/base-ubuntu:jammy-20231128
LABEL maintainer "David J. M. Karlsen <[email protected]>"
ARG JDK_VERSION=17.0.7+7
ARG DOWNLOAD_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.7%2B7/OpenJDK17U-jdk_x64_linux_hotspot_17.0.7_7.tar.gz
ARG JDK_VERSION=17.0.12+7
ARG DOWNLAOD_URL=https://github.com/adoptium/temurin17-binaries/releases/download/jdk-17.0.12%2B7/OpenJDK17U-jdk_x64_linux_hotspot_17.0.12_7.tar.gz
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Spelling mistake in the environment variable here. Should be DOWNLOAD_URL not DOWNLAOD_URL

oysvendsen marked this conversation as resolved.
Show resolved Hide resolved
SHELL ["/bin/bash", "-o", "pipefail", "-c"]
RUN mkdir -p /usr/lib/jvm && \

Check failure on line 6 in Dockerfile

View workflow job for this annotation

GitHub Actions / build 

SC2086 info: Double quote to prevent globbing and word splitting.
curl -Ls ${DOWNLOAD_URL} | tar xzv -C /usr/lib/jvm && \
sh -c 'for bin in /usr/lib/jvm/jdk-${JDK_VERSION}/bin/*; do update-alternatives --install /usr/bin/$(basename $bin) $(basename $bin) $bin 100 ;done' && \
sh -c 'for bin in /usr/lib/jvm/jdk-${JDK_VERSION}/bin/*; do update-alternatives --set $(basename $bin) $bin; done' && \
Expand Down
Loading