Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR proposes adding return type hints to a few methods that were missing them. This improves the ability of type checkers like
mypy
to catch type-checking issues like "this method can returnNone
but its output is being used unconditionally as if it were notNone
".Question for Reviewers
These are just a few things I saw while starting to familiarize myself with this codebase. There are other methods missing return type hints... would you support additional PRs like this adding return type hints?
I saw mixed use of them throughout the project, but assume they're desirable since
mypy
is run in CI:evidently/.github/workflows/main.yml
Lines 57 to 58 in 53bda86
If this type of contribution is annoying and you aren't open to more such PRs, please do tell me and I won't propose more.
Thanks very much for your time and consideration!