Metrics redesign #1389
Draft
Metrics redesign #1389
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mike0sv
reviewed
Dec 10, 2024
|
|
||
| @dataclasses.dataclass | ||
| class ColumnInfo: | ||
| type: ColumnType |
There was a problem hiding this comment.
usually renamed as type_ to not collide with type
mike0sv
reviewed
Dec 10, 2024
src/evidently/v2/datasets.py
Outdated
| self.data = data | ||
|
|
||
|
|
||
| class Scorer: |
There was a problem hiding this comment.
need to think about naming, this class most definitely does not do "scoring" :)
mike0sv
reviewed
Dec 10, 2024
| return ColumnType.Unknown | ||
|
|
||
|
|
||
| class DatasetColumn: |
mike0sv
reviewed
Dec 10, 2024
| self._alias = alias | ||
|
|
||
| @abc.abstractmethod | ||
| def generate_data(self, dataset: "Dataset") -> Union[DatasetColumn, Dict[str, DatasetColumn]]: |
There was a problem hiding this comment.
I try to avoid unions, because every it means i will need to do instance check somewhere. How about we use general interface with a dict, but have something like SingleColumnScorer that will delegate this method to another abs method that returns a single DatasetColumn?
mike0sv
reviewed
Dec 10, 2024
| raise NotImplementedError() | ||
|
|
||
| @property | ||
| def alias(self) -> str: |
mike0sv
reviewed
Dec 10, 2024
src/evidently/v2/metrics/base.py
Outdated
| class MetricResult: | ||
| _widget: Optional[List[BaseWidgetInfo]] = None | ||
|
|
||
| def set_widget(self, widget: List[BaseWidgetInfo]): |
Allow multiple scorer with same names (auto suffix).
* codegen scorers * rename and skip * add alias * imports * remove display name
Update metric_workbench.ipynb to use descriptors instead of Scorers.
* support v2 metrics in v1 snapshots * plot * v1 to v2 compat * update stuff * fix * revert pydantic * revert pydantic * revert pydantic * merge * merge * rename scorers->descriptors
…eature/metrics-redesign
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.