Skip to content

Commit

Permalink
UI(refacor): merge code-check job with type-check job (#1304)
Browse files Browse the repository at this point in the history
  • Loading branch information
DimaAmega authored Sep 15, 2024
1 parent 05023a3 commit 68f56f7
Showing 1 changed file with 5 additions and 18 deletions.
23 changes: 5 additions & 18 deletions .github/workflows/ui.yml
Original file line number Diff line number Diff line change
Expand Up @@ -57,29 +57,12 @@ jobs:
echo "One or more evidently_python file(s) has changed."
echo "List all the files that have changed: ${{ steps.changed-files.outputs.evidently_python_all_changed_and_modified_files }}"
code-check:
ui-code-check:
name: UI code-check
runs-on: ubuntu-22.04
needs: changed_files
if: ${{ github.event.pull_request.draft == false && (needs.changed_files.outputs.ui_any_modified == 'true' || needs.changed_files.outputs.evidently_python_any_modified == 'true') }}

steps:
- name: ⬇️ Checkout repo
uses: actions/checkout@v4

- name: 📥 Install ui dependencies
uses: ./.github/share-actions/ui-node-pnpm-install

- name: 🔬 Check code quality
working-directory: ui
run: pnpm code-check

ui-type-check:
name: UI type-check
runs-on: ubuntu-22.04
needs: changed_files
if: ${{ github.event.pull_request.draft == false && (needs.changed_files.outputs.ui_any_modified == 'true' || needs.changed_files.outputs.evidently_python_any_modified == 'true') }}

steps:
- name: ⬇️ Checkout repo
uses: actions/checkout@v4
Expand All @@ -94,6 +77,10 @@ jobs:
working-directory: ui
run: pnpm type-check

- name: 🔬 Check code quality
working-directory: ui
run: pnpm code-check

ui-deps-analyze:
name: UI deps analyze
runs-on: ubuntu-22.04
Expand Down

0 comments on commit 68f56f7

Please sign in to comment.