Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix add Swift version to podspec file #41

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

hons82
Copy link

@hons82 hons82 commented Sep 13, 2016

Without this you have to manually specify the Swift version every time you do a pod update or pod install

Without this you have to manually specify the Swift version every time you do a pod update or pod install
@evgenyneu
Copy link
Owner

Hi @hons82, thanks for the update. Is this setting documented yet on CocoaPods web site? I could not find anything.

@hons82
Copy link
Author

hons82 commented Sep 19, 2016

I'm not sure about that...
Using the current Cocoapods you'll need that setting to be set manually with the podspec file.
Using the RC you can add a .swift-version file to your repo specifying the version.

We did both in this repo just to be sure

@evgenyneu
Copy link
Owner

Ok, I think we can wait for some official documentation first before merging this. Thanks.

@hristouzunovaz
Copy link

hristouzunovaz commented Dec 21, 2016

Hi @evgenyneu, what is the status of this PR. I was migrating my project from Swift 2.2 to Swift 3 in Xcode 8.1, and it turns out Xcode cannot correctly infer the SWIFT_VERSION. What I see in the Build Settings of the project is Unsupported Version: 3.0, while I believe it expects something else.

@evgenyneu
Copy link
Owner

Hi @hristouzunovaz, I am still waiting for cocoapods to officially implement the swift version setting in the podspec file. As written here, cocoapods "defaults to Swift 3.0". I would like to know:

  • What exactly is your build error, could you please send a screenshot and full error text?
  • What is the version of KeychainSwift in your Podfile?
  • What version of cocoapods are you using pod --version?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants