Fix datatables properly #668
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The second round of issues was caused by outdated datatables plugins that didn't work with the new datatables core file from last PR.
To make sure everything compatible with everything, this PR replaces all datatables files (core, plugins, css) with a fresh version pulled from their download builder over at https://datatables.net/download/
As for the configuration, I've included
The download builder bundles everything in one files, so all the separate files for plugins were removed.
Since the core now includes everything needed, I additionally removed the dependency on all datatables packagist packages.