Show alt characters in character summary when token has expired #657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm pretty sure the CI failure is unrelated to this, since this PR doesn't touch code that failed |
|
Not sure what happened there, completed successfully when I requested it rerun. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes eveseat/seat#856
It is currently broken since character with expired tokens have their
refresh_tokensoft-deleted. This means currently SeAT can't find the user from a character with expired token sincerefresh_tokenslinks characters to a user. The fix is to also consider deleted tokens when searching the user from a character.The
global.invalid_tokenspermission is respected since it only affectsuser->altsand not the first part of the chain,character->user