Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-12427: Add test to verify that filters with commas are parsed correctly #709

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

DEVPROD-12427: Add test to verify that filters with commas are parsed correctly #709

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
1e97e3e
DEVPROD-12427: Add test to verify that filters with commas are parsed…
minnakt Mar 20, 2025
ce27b86
Codegen
minnakt Mar 20, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
15 changes: 15 additions & 0 deletions apps/parsley/cypress/integration/project_filters.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,21 @@ describe("project filters", () => {
cy.get("[data-cy^='skipped-lines-row-']").should("exist");
});

it("properly processes filters with commas", () => {
cy.visit(resmokeLogLink);
cy.contains("View project filters").click();
cy.dataCy("project-filters-modal").should("be.visible");
cy.getInputByLabel('"Connection accepted","attr"').check({
force: true,
});
cy.contains("button", "Apply filters").click();
cy.location("search").should(
"contain",
"110%2522Connection%2520accepted%2522%252C%2522attr%2522",
);
cy.get("[data-cy^='skipped-lines-row-']").should("exist");
});

it("should disable checkbox if filter is already applied", () => {
cy.visit(`${resmokeLogLink}?filters=100D%255Cd`);
cy.contains("View project filters").click();
Expand Down
3 changes: 0 additions & 3 deletions apps/parsley/src/gql/generated/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1540,8 +1540,6 @@ export type Notifications = {
__typename?: "Notifications";
buildBreak?: Maybe<Scalars["String"]["output"]>;
buildBreakId?: Maybe<Scalars["String"]["output"]>;
commitQueue?: Maybe<Scalars["String"]["output"]>;
commitQueueId?: Maybe<Scalars["String"]["output"]>;
patchFinish?: Maybe<Scalars["String"]["output"]>;
patchFinishId?: Maybe<Scalars["String"]["output"]>;
patchFirstFailure?: Maybe<Scalars["String"]["output"]>;
Expand All @@ -1554,7 +1552,6 @@ export type Notifications = {

export type NotificationsInput = {
buildBreak?: InputMaybe<Scalars["String"]["input"]>;
commitQueue?: InputMaybe<Scalars["String"]["input"]>;
patchFinish?: InputMaybe<Scalars["String"]["input"]>;
patchFirstFailure?: InputMaybe<Scalars["String"]["input"]>;
spawnHostExpiration?: InputMaybe<Scalars["String"]["input"]>;
Expand Down