DEVPROD-5777 Skip sending GitHub status for disabled commit queue #7788
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ablack12
requested changes
Apr 24, 2024
rest/data/commit_queue.go
Outdated
| if err == nil { | ||
| return nil | ||
| } | ||
|
|
||
| catcher := grip.NewBasicCatcher() | ||
| catcher.Wrap(thirdparty.SendCommitQueueGithubStatus(ctx, env, pr, message.GithubStateFailure, err.Error(), ""), "sending GitHub status update") | ||
| if !skipStatus { | ||
| catcher.Wrap(thirdparty.SendCommitQueueGithubStatus(ctx, env, pr, message.GithubStateFailure, err.Error(), ""), "sending GitHub status update") |
There was a problem hiding this comment.
Branch protection rules might apply even for projects that aren't using the new commit queue. Could we just remove this entirely and only post the comment in all cases? The original ticket / PR only ever really mentioned sending a comment. (#6499)
bynn
changed the title
ablack12
approved these changes
Apr 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-5777
Description
sending a status for disabled evergreen queue will prevent some repos from merging if they require all checks to pass
the change will only make a github comment on the PR
Testing
staging
evergreen-ci/commit-queue-sandbox#692
does not send the status but writes the comment