Refactored the event store definition to include the optimistic concurrency checks #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rrency checks Adjusted typing to keep StreamVersion part of the Event Store definition, defaulting to bigint. Added typings for input options and result to include cases where stream may not exists and user provides expected version (or not). Made aggregateStream and readStream method take expectedStreamVersion to fail fast.
oskardudycz
force-pushed
the
optimistic_concurrency
branch
from
e36273d to
c2edf2e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
bigint.aggregateStreamandreadStreammethods takeexpectedStreamVersionto fail fast.DeciderCommandHandlerdefinition to reuse regularCommandHandler@watfordsuzy FYI
Relates to #10, the InMemory and EventStoreDB implementations will come in the follow up PRs.