Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Loadpoint: add solar share setting (experimental) #16507

Open
wants to merge 15 commits into
base: master
Choose a base branch
from
Open

Conversation

andig
Copy link
Member

@andig andig commented Oct 5, 2024

Refs #6192. Depends on #16274.

This PR adds a new solarShare setting that determines how much solar energy is required to start or continue the charging process in percent. This could eventually replace the loadpoint enable/disable thresholds. Values >100% and <0% are (technically) possible. Setting is only active if solar share is set.

For time being, API-only:

POST /api/loadpoints/<id>/solarshare/0.75
DELETE /api/loadpoints/<id>/solarshare

TODO

  • add tests

Out of scope

@andig andig added enhancement New feature or request experimental Experimental feature labels Oct 5, 2024
@andig andig marked this pull request as draft October 5, 2024 10:28
@naltatis
Copy link
Member

naltatis commented Oct 7, 2024

Konsequenz ist hier, dass der Aktivierungs- und Deaktivierungsschwelle immer gleich sind. Find ich aber eine gute Vereinfachung.

Zur API: Gepublisht wird ein Wert zwischen 0-1, die REST API arbeitet mit 0-100. Aktuell haben wir bereits greenShare[Home|Loadpoint], die auch mit 0-1 arbeiten. Ich glaub ich würd aus Konsistenzgründen bei der REST API das Scale rausnehmen und auch da einfach das Float entgegennehmen.

@andig andig marked this pull request as ready for review October 12, 2024 11:51
@andig andig added the needs documentation Triggers issue creation in evcc-io/docs label Oct 12, 2024
@VolkerK62
Copy link
Contributor

VolkerK62 commented Oct 12, 2024

Hmm .... hab ich einen Denkfehler?
solarShare = 0.5
effect.MinPower = 1400W

enableThreshold = -*solarShare * lp.EffectiveMinPower() = -0.5 * 1400W = -700W
disableThreshold = (*solarShare - 1) * lp.EffectiveMinPower() = (0.5 -1) * 1400W = -700W

Müsste disable nicht +700W sein? Sonst wird doch sofort wieder ausgeschaltet?

Edit:
Ach, oder ist das das Ding mit projectedSitePower?

@andig
Copy link
Member Author

andig commented Oct 12, 2024

Disable ist doch genau so wie heute?

@VolkerK62
Copy link
Contributor

Sure?
Wenn ich das Beispiel aktuell abbilde, dann würde ich
enable: -700
disable: 700
einstellen.
Bei 700W Überschuss ist Ladestart, mit minPower hab ich dann 700 Netzbezug.

@github-actions github-actions bot added the stale Outdated and ready to close label Oct 20, 2024
@andig andig added backlog Things to do later and removed enhancement New feature or request stale Outdated and ready to close labels Oct 21, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backlog Things to do later experimental Experimental feature needs documentation Triggers issue creation in evcc-io/docs
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants