Improve synchronisation of the pairing code message. #10
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If this sounds good. I'll send another one for stretch. |
|
This looks fine. FYI, I wasn't planning on doing any more ev3dev-jessie releases. We can still update the brickman package though if people are using it for OpenRoberta. Adding a --version command line option is OK too. |
We did send the code to the server and showed the code at the same time. This will let the user enter the code before we managed to connect. Now we show a "connecting..." message first and only show the code when we conencted. See OpenRoberta/robertalab-ev3dev#30
This can be used to quickly check the version :)
$ /usr/sbin/brickman --version
brickman v0.8.1I'll prepare another pull request for stretch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We did send the code to the server and showed the code at the same time.
This will let the user enter the code before we managed to connect. Now
we show a "connecting..." message first and only show the code when we
conencted.
See OpenRoberta/robertalab-ev3dev#30