Skip to content

Add check collision #232

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 17, 2015
Merged

Add check collision #232

merged 3 commits into from
Jul 17, 2015

Conversation

snozawa
Copy link
Contributor

@snozawa snozawa commented Jul 16, 2015

Add :check-collision argument to IK according to #95.
check-collision is nil by default to keep compatibility.

  • If check-collision is nil, IK results are same as before.
  • If check-collision is t, :inverse-kinematics success will be IK success and no collision

Note that I added :make-pqpmodel by default in :init-ending.

I added test code to irteus/test.

@k-okada
Copy link
Member

k-okada commented Jul 17, 2015

lgtm, please include file name (+ function name) into commit log, to help writing CHANGELOG.rst
(when we create CHANGELOG, we edit from the results of git log --oneline)
https://github.com/euslisp/jskeus/blob/master/CHANGELOG.rst

@snozawa snozawa force-pushed the add_checkcollision branch from ed47125 to 0c6febd Compare July 17, 2015 02:18
@snozawa
Copy link
Contributor Author

snozawa commented Jul 17, 2015

Thank you for your advice.

I updated PR by adding file name referring https://github.com/euslisp/jskeus/blob/master/CHANGELOG.rst. (Function names are already added).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants