Support #Preview parsing (iOS 17+ only) #50
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
UIVieworUIViewControllerin iOS 17#Previewis currently not supported because the view factory used by SwiftUI is exposed as@MainActor () -> UIView, but since we now use Swift 6 compiler, it cannot be casted directly to@MainActor @Sendable () -> UIView(@MainActornow implies@Sendable)https://forums.swift.org/t/is-there-any-real-difference-between-mainactor-sendable-and-mainactor/72525/8
https://github.com/swiftlang/swift-evolution/blob/main/proposals/0434-global-actor-isolated-types-usability.md
We still need a way to filter out unwantedSince the list is now grouped by modules, this is not an issue anymore#Previews (ex: Previews inside the StoryBookKit are also being extracted). I'm currently looking atPreview.ViewTraitsif this is customizable for our own use