Widgets for the conditional fields #280
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Requires euphorie/Euphorie#761 for this to work |
ale-rt
changed the title
They prevent client side validation to kick in when the conditions that show the fields are not met. Refs. syslabcom/scrum#2615
ale-rt
force-pushed
the
ale/quaive-app/widget-for-conditional-fields
branch
from
2332a31
to
8fc144d
Compare
mauritsvanrees
approved these changes
Sep 11, 2024
There was a problem hiding this comment.
This is mostly working fine. I have merged the Euphorie PR.
I see one problem though. The error is shown twice for rich text fields. For example when editing a survey and enabling the custom notification:
So the html/textarea widget seems to already show its error without needing the explicit showing of an error as this PR does. But for the simple text line widget, it is needed.
I approve the PR because this is an improvement, but I won't merge yet. You can decide if you merge and then open a new issue, or if you try to fix it first.
|
Sure, I will fix it :) Thanks a lot! |
|
Thanks, that works. |
mauritsvanrees
deleted the
ale/quaive-app/widget-for-conditional-fields
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
They prevent client side validation to kick in when the conditions that show the fields are not met.
Refs. https://github.com/syslabcom/scrum/issues/2615