Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Attestation-based client authentication support #107

Conversation

dtsiflit
Copy link
Contributor

Description of change

PR aims to provide support attestation-base client (wallet) authentication.

  • New enum named Client having two cases public and attested. Client would express the OAUTH2 client and in particular the way that it can be authenticated to token and/or PAR endpoint
  • Assume that the attested case has already a ClientAttestationJWT. How this is provisioned is outside the scope of the PR
  • Replace clientId with client in OpenId4VCIConfig
  • Take into account Wallet Attestation Schema from HAIP

Closes #75

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dtsiflit dtsiflit requested a review from a team as a code owner January 31, 2025 08:46
@dtsiflit dtsiflit marked this pull request as draft January 31, 2025 08:46
@dtsiflit dtsiflit self-assigned this Jan 31, 2025
@dtsiflit dtsiflit marked this pull request as ready for review February 12, 2025 11:43
@dtsiflit dtsiflit merged commit ac88f27 into eu-digital-identity-wallet:main Feb 12, 2025
2 checks passed
@dtsiflit dtsiflit deleted the feature/attestation-based-client branch February 12, 2025 13:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support Attestation-Based Client Authentication
1 participant