Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Back to Lower minSDK = API Level 23 - MM6.0 #202

Open
wants to merge 61 commits into
base: main
Choose a base branch
from

Commits on Sep 7, 2021

  1. Back to Lower minSDK = API Level 23 - MM6.0

    An additional gradle dependency for jackson-datatype-jsr310 is required in order to lower minSDK again from API 26 (Oreo 8.0) to API 23 (Marshmallow 6.0).
    
    It allows indeed Jackson to recognize Java 8 Date & Time API data types (JSR-310) when desugaring has been set/enabled in app/build.gradle + minSDK=23 & the dgca-verifier-app is running on Android 23<=API<26 devices.
    
    Otherwise, an exception is raised.
    
    ------
    
    Other changes :
    
    - Changed zxing:core from 3.3.0 to 3.3.2 (default version for zxing-android-embedded 3.6.0) = working OK with API 23+ devices
    
    -  XML android:paddingHorizontal triggers a LINT error when minSDK <26. Replaced with paddingLeft/paddingRight in order to avoid LINT rules override = AAPT2 2.19 could support backwards translation, but it would have required to disable/override LINT checks.
    rawmain committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    5e76064 View commit details
    Browse the repository at this point in the history
  2. Create android.yml

    rawmain authored Sep 7, 2021
    Configuration menu
    Copy the full SHA
    2a8252a View commit details
    Browse the repository at this point in the history
  3. Back to Lower minSDK = API Level 23 - MM6.0

    An additional gradle dependency for jackson-datatype-jsr310 is required in order to lower minSDK again from API 26 (Oreo 8.0) to API 23 (Marshmallow 6.0).
    
    It allows indeed Jackson to recognize Java 8 Date & Time API data types (JSR-310) when desugaring has been set/enabled in app/build.gradle + minSDK=23 & the dgca-verifier-app is running on Android 23<=API<26 devices.
    
    Otherwise, an exception is raised.
    
    ------
    
    Other changes :
    
    - Changed zxing:core from 3.3.0 to 3.3.2 (default version for zxing-android-embedded 3.6.0) = working OK with API 23+ devices
    
    -  XML android:paddingHorizontal triggers a LINT error when minSDK <26. Replaced with paddingLeft/paddingRight in order to avoid LINT rules override = AAPT2 2.19 could support backwards translation, but it would have required to disable/override LINT checks.
    rawmain committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    41925e2 View commit details
    Browse the repository at this point in the history
  4. Create android.yml

    rawmain committed Sep 7, 2021
    Configuration menu
    Copy the full SHA
    9af1f79 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    68ab2a6 View commit details
    Browse the repository at this point in the history

Commits on Sep 10, 2021

  1. Configuration menu
    Copy the full SHA
    07ed537 View commit details
    Browse the repository at this point in the history

Commits on Sep 14, 2021

  1. Configuration menu
    Copy the full SHA
    49cd849 View commit details
    Browse the repository at this point in the history

Commits on Sep 15, 2021

  1. Delete android.yml

    rawmain authored Sep 15, 2021
    Configuration menu
    Copy the full SHA
    2d92e9d View commit details
    Browse the repository at this point in the history

Commits on Sep 19, 2021

  1. Configuration menu
    Copy the full SHA
    a368d50 View commit details
    Browse the repository at this point in the history

Commits on Sep 20, 2021

  1. Configuration menu
    Copy the full SHA
    201e809 View commit details
    Browse the repository at this point in the history

Commits on Sep 22, 2021

  1. Configuration menu
    Copy the full SHA
    a23e0cc View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    8eba435 View commit details
    Browse the repository at this point in the history

Commits on Sep 27, 2021

  1. Configuration menu
    Copy the full SHA
    e5a8642 View commit details
    Browse the repository at this point in the history

Commits on Sep 30, 2021

  1. Configuration menu
    Copy the full SHA
    b5da043 View commit details
    Browse the repository at this point in the history

Commits on Oct 1, 2021

  1. Configuration menu
    Copy the full SHA
    4802957 View commit details
    Browse the repository at this point in the history

Commits on Oct 11, 2021

  1. Configuration menu
    Copy the full SHA
    a1e95a2 View commit details
    Browse the repository at this point in the history

Commits on Oct 15, 2021

  1. Configuration menu
    Copy the full SHA
    c1b95c5 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2021

  1. Configuration menu
    Copy the full SHA
    ecbe5ab View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2021

  1. Configuration menu
    Copy the full SHA
    b70447a View commit details
    Browse the repository at this point in the history
  2. Remove Guava Version

    rawmain committed Nov 17, 2021
    Configuration menu
    Copy the full SHA
    1e3308b View commit details
    Browse the repository at this point in the history

Commits on Dec 31, 2021

  1. Configuration menu
    Copy the full SHA
    d3e069d View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2022

  1. Configuration menu
    Copy the full SHA
    fdc9f9e View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2022

  1. Applied Reviewed changes

    - Removed old unncessary comments
    
    - Aligned jackson.datatype implementation with others (Deps dependencies URL)
    rawmain committed Feb 3, 2022
    Configuration menu
    Copy the full SHA
    66b3ae9 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2022

  1. Configuration menu
    Copy the full SHA
    2efcf74 View commit details
    Browse the repository at this point in the history

Commits on Mar 9, 2022

  1. Configuration menu
    Copy the full SHA
    ff03a05 View commit details
    Browse the repository at this point in the history
  2. Revocation Desugaring Fix 01

    rawmain committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    0559bdc View commit details
    Browse the repository at this point in the history
  3. iterator Debug Lint Fix 02

    Added iterator() in order to avoid the confusion - between the Kotlin Iterable.forEach extension function and the Java8 forEach function -  on debug variants while desugaring
    rawmain committed Mar 9, 2022
    Configuration menu
    Copy the full SHA
    882aff8 View commit details
    Browse the repository at this point in the history

Commits on Mar 10, 2022

  1. jackson-datatype-jsr310 Revocation dep Fix 03

    Additional gradle dependency for jackson-datatype-jsr310 in revocation project too
    rawmain authored Mar 10, 2022
    Configuration menu
    Copy the full SHA
    3710180 View commit details
    Browse the repository at this point in the history

Commits on Mar 17, 2022

  1. Configuration menu
    Copy the full SHA
    e54620a View commit details
    Browse the repository at this point in the history
  2. HashFilter Desugaring Fix 04

    - Using Collections.sort method to sort arrayList in natural order
    
    - Replaced hashFilterList.forEach with hashFilterList.iterator().forEach in order to avoid the confusion - between the Kotlin Iterable.forEach extension function and the Java8 forEach function -  on debug variants while desugaring.
    rawmain committed Mar 17, 2022
    Configuration menu
    Copy the full SHA
    1313066 View commit details
    Browse the repository at this point in the history

Commits on Mar 21, 2022

  1. Configuration menu
    Copy the full SHA
    ffe9890 View commit details
    Browse the repository at this point in the history

Commits on Mar 28, 2022

  1. Configuration menu
    Copy the full SHA
    990d80f View commit details
    Browse the repository at this point in the history

Commits on Mar 29, 2022

  1. Configuration menu
    Copy the full SHA
    0d826dc View commit details
    Browse the repository at this point in the history

Commits on Mar 30, 2022

  1. Configuration menu
    Copy the full SHA
    9195b10 View commit details
    Browse the repository at this point in the history

Commits on Apr 1, 2022

  1. Configuration menu
    Copy the full SHA
    8d0ed88 View commit details
    Browse the repository at this point in the history

Commits on Jun 28, 2022

  1. Configuration menu
    Copy the full SHA
    d84a363 View commit details
    Browse the repository at this point in the history
  2. Branches Base minSdk 23

    Aligned minSdk declaration in library [:branches:base]
    rawmain committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    c5c7cc5 View commit details
    Browse the repository at this point in the history
  3. Desugaring Branches Fix 01

    Apply Desugaring Edits to branches\dcc build.gradle
    rawmain committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    1bd8222 View commit details
    Browse the repository at this point in the history
  4. Desugaring Branches Fix 02

    Apply Desugaring Edits to branches\vc build.gradle
    rawmain committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    e2b6111 View commit details
    Browse the repository at this point in the history
  5. iterator Fix 01

    Added iterator() in order to avoid the confusion - between the Kotlin Iterable.forEach extension function and the Java8 forEach function -  while desugaring
    rawmain committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    cd0d0ee View commit details
    Browse the repository at this point in the history
  6. padding fix 01

    android:paddingHorizontal requires API level 26 - replaced with paddingLeft/paddingRight (API 23 compatibility)
    rawmain committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    2113a8f View commit details
    Browse the repository at this point in the history
  7. Gradle Scripts Desugaring Alignment

    Aligned desugaring edits for app/branches gradle scripts (in order to avoid runtime issues on device with API level < 26)
    rawmain committed Jun 28, 2022
    Configuration menu
    Copy the full SHA
    ea357b8 View commit details
    Browse the repository at this point in the history

Commits on Aug 29, 2022

  1. Configuration menu
    Copy the full SHA
    435e7b7 View commit details
    Browse the repository at this point in the history

Commits on Aug 30, 2022

  1. Configuration menu
    Copy the full SHA
    3826f07 View commit details
    Browse the repository at this point in the history
  2. [Test] Increase Gradle daemon memory size

    Increase Gradle daemon memory size in order to prevent "GC overhead limit exceeded" exception errors
    rawmain authored Aug 30, 2022
    Configuration menu
    Copy the full SHA
    6b8617f View commit details
    Browse the repository at this point in the history

Commits on Nov 23, 2022

  1. Configuration menu
    Copy the full SHA
    5f40b58 View commit details
    Browse the repository at this point in the history
  2. Update AppConfig.kt

    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    9a51679 View commit details
    Browse the repository at this point in the history
  3. Revert Java Version

    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    47b1695 View commit details
    Browse the repository at this point in the history
  4. Testing Desugaring 2.0.0

    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    a4c3b10 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0b4b02a View commit details
    Browse the repository at this point in the history
  6. Revert to Desugaring 1.1.5

    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    700d7dc View commit details
    Browse the repository at this point in the history
  7. Update DefaultProtocolHandler.kt

    Explicited iterator() in order to avoid lint errors without changing gradle version because of the confusion - between the Kotlin Iterable.forEach extension function and the Java8 forEach function - on debug variants (owing to desugaring)
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    8ac1091 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    6341489 View commit details
    Browse the repository at this point in the history
  9. Upgraded Desugaring to 2.0.0

    Upgraded Desugaring Libs from 1.1.5 to 2.0.0.
    
    Related dependency/plugin changes :
    
    - Gradle Wrapper 6.5 -> 7.5.1
    - AGP (Android Gradle Plugin) 4.1.3 -> 7.4.0-beta05
    
    - Hilt (Dagger) 2.38.1 -> 2.42
    - Removed dependency androidx.hilt:hilt-lifecycle-viewmodel - since it's already included in Hilt 2.42
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    ddafc7a View commit details
    Browse the repository at this point in the history
  10. [Test] Fix for Github CI Workflow

    Edit in order to fix "Gradle build daemon disappeared unexpectedly (it may have been killed or may have crashed)" with Github Actions
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    c62e81f View commit details
    Browse the repository at this point in the history
  11. Increase MaxMetaspaceSize

    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    7809d4b View commit details
    Browse the repository at this point in the history
  12. Arrange GRADLE_OPTS

    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    448a70f View commit details
    Browse the repository at this point in the history
  13. disable ExpiredTargetSdkVersion for decoder

    Github Actions with AGP 7.4.0-beta05 incorrectly triggers a LINT error with decoder module.
    
    Such edit allows to bypass this bug.
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    49f519b View commit details
    Browse the repository at this point in the history
  14. disable ExpiredTargetSdkVersion for decoder

    Github Actions with AGP 7.4.0-beta05 incorrectly triggers a LINT error with decoder module.
    
    Such edit on project gradle allows to bypass this bug for all modules
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    6a7ed9d View commit details
    Browse the repository at this point in the history
  15. DCC Manifest Edit for Zxing

    Edit in order to avoid bug with Github Action - Manifest merger failed : uses-sdk:minSdkVersion 23 cannot be smaller than version 24 declared in library [com.journeyapps:zxing-android-embedded:4.2.0]
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    8519105 View commit details
    Browse the repository at this point in the history
  16. DCC Manifest Edit for Zxing

    Edit in order to avoid bug with Github Action - Manifest merger failed : uses-sdk:minSdkVersion 23 cannot be smaller than version 24 declared in library [com.journeyapps:zxing-android-embedded:4.2.0]
    rawmain committed Nov 23, 2022
    Configuration menu
    Copy the full SHA
    23e67b4 View commit details
    Browse the repository at this point in the history