add VaultTemplate to SigningServiceImpl #101
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
skreisig
force-pushed
the
feature/extend_signing_service
branch
from
dc38e12
to
262b4f7
Compare
SchulzeStTSI
suggested changes
Jul 21, 2022
There was a problem hiding this comment.
Please create for the Vault and seperated Signing Implementation. For this the singing interface should be refactored to just accept "hash" without any private key (should be handled by the implementation). Additionally the two signing variants should be enabled and disabled by profiles:)
skreisig
force-pushed
the
feature/extend_signing_service
branch
from
262b4f7
to
9c4f9e7
Compare
|
Kudos, SonarCloud Quality Gate passed! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.