Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for alternative Revoke Endpoint #28

Open
f11h opened this issue May 17, 2021 · 4 comments
Open

Add support for alternative Revoke Endpoint #28

f11h opened this issue May 17, 2021 · 4 comments
Labels
enhancement New feature or request

Comments

@f11h
Copy link
Collaborator

f11h commented May 17, 2021

Current Implementation

The connector is using the DELETE /signerCertificate endpoint to revoke a certificate.

Suggested Enhancement

Optionally use the new alternative endpoint POST /signerCertificate/delete from eu-digital-green-certificates/dgc-gateway#64

The usage of this alternative endpoint should be configurable.

Expected Benefits

Users with clients behind Load Balancers which do not allow DELETE Request with Payload can also send revoke requests to DGCG.

@gregsons
Copy link

Hi @f11h , when it's planned to add this support?

@f11h
Copy link
Collaborator Author

f11h commented May 26, 2021

Hi @gregsons, I will try to do it within this week.
Maybe you are able to provide a PR with a suggestion on how to implement it?

@gregsons
Copy link

Hello @f11h ,
We managed to implement a workaround in our national backend, so from PL's perspective there's no need to add support in dgc-lib.

@f11h
Copy link
Collaborator Author

f11h commented May 26, 2021

Oh thats good to hear - Then I will remove it from my "personal backlog". But I will not delete this task, maybe I will find some time late to implement it :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants