Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signer Delete Interface (signerCertificate) #63

Closed
gregsons opened this issue May 14, 2021 · 7 comments · Fixed by #64
Closed

Signer Delete Interface (signerCertificate) #63

gregsons opened this issue May 14, 2021 · 7 comments · Fixed by #64
Assignees
Labels
question Further information is requested

Comments

@gregsons
Copy link

gregsons commented May 14, 2021

Your Question

  1. Add PUT operation for signerCertificate endpoint or
  2. Add POST/PUT operation for new endpoint

We're currently using ESB WSO2 for forwarding requests to Gateway which doesn't give possibility to forward data in body for DELETE operation. It can be configured only for GET:
https://docs.wso2.com/display/EI650/HTTP+Transport+Properties#HTTPTransportProperties-NO_ENTITY_BODY

@gregsons gregsons added the question Further information is requested label May 14, 2021
@f11h
Copy link
Contributor

f11h commented May 17, 2021

Hi @gregsons ,

a payload in a DELETE-Request is not violating any RFC in any form.

The way of deleting/ revoking certificates was changed because it was required to also sign delete requests with your uploader certificate. (Please mind: It is not only moving the hash from header to body).
The delete/ revoke endpoint works exactly like the upload endpoint. (regarding payload and payload validation).

As I can see in the linked documentation this property only affects GET requests. Have you tried sending a delete message via this proxy?

@f11h f11h self-assigned this May 17, 2021
@gregsons
Copy link
Author

Hi @f11h ,
Yes, we've tried and ESB WSO2 by default deletes any payload in body part for DELETE requests. For version we're using (6.5.0), the defualt behavior can be changed to not deleting body part, but only for GET requests.
That's why proposal for [1] or [2] in the first post.

@f11h
Copy link
Contributor

f11h commented May 17, 2021

Hi @gregsons ,

I've created a PR to adress your issue. This PR introduces an alias for accessing the delete endpoint.
This can be used with

POST /signerCertificate/delete

Payload: Signed CMS Message

@gregsons
Copy link
Author

@f11h thank you, would it be possible to add support for /signerCertificate/delete also in dgc-lib?

@f11h
Copy link
Contributor

f11h commented May 17, 2021

Yes, I will think about it how to integrate it the best way

@f11h f11h closed this as completed in #64 May 17, 2021
@f11h
Copy link
Contributor

f11h commented May 17, 2021

I've created an issue in dgc-lib project to introduce the feature: eu-digital-green-certificates/dgc-lib#28

@gregsons
Copy link
Author

Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants