Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent FFMPEG build warning from causing compilation error #1314

Merged

Commits on Jul 30, 2024

  1. Prevent FFMPEG build warning from causing compilation error

    The specific error was
    ```
    /Users/runner/work/etterna/etterna/main/build/ffmpeg_dl/ffmpeg-2.1.3-src/libavcodec/flvenc.c:96:23: error: incompatible function pointer types initializing 'int (*)(AVCodecContext *, AVPacket *, const AVFrame *, int *)' (aka 'int (*)(struct AVCodecContext *, struct AVPacket *, const struct AVFrame *, int *)') with an expression of type 'int (AVCodecContext *, AVPacket *, AVFrame *, int *)' (aka 'int (struct AVCodecContext *, struct AVPacket *, struct AVFrame *, int *)') [-Wincompatible-function-pointer-types]
        .encode2        = ff_MPV_encode_picture,
                          ^~~~~~~~~~~~~~~~~~~~~
    1 error generated.
    make: *** [libavcodec/flvenc.o] Error 1
    ```
    
    when trying to build for aarch64 on the Sonoma Github M1 runner
    
    I believe this ffmpeg warning was likely fixed a long, long time
     ago; we're running an ancient version right now.
    bluebandit21 committed Jul 30, 2024
    Configuration menu
    Copy the full SHA
    57ceae6 View commit details
    Browse the repository at this point in the history