Bootstrap & Stuff #40
Conversation
-Added FontAwesome -Added .IDEA -Formated canvas.js -Improved canvas.js --Unterminated statements --Duplicated declarations --Line 289 was a condition instead of a comparasion --Line 293 Changed comparison of any type of var to only the same type as the var to compare (== -> ===) --Line 318 lineNumber++ * 1 replaced with lineNumber++ -Formated index.html -Improved index.html --Script and Style Tags -Formated ramos.js
|
Hola estimado, se agradece la intención de aportar para mejorar la malla, probé la rama para ver visualmente cuales fueron los cambios y me surgieron un par de problemas:
Saludos! |
|
Hola! 1.- En local funcionaban perfectamente en PC y Celulares (ya sea LAN y/o Ngrok), igualmente probaré nuevamente para descartar problemas de Cache. 2.- Se realizó formato y mejoras solo al Index por el momento 3.- Mantener archivos como .idea pueden ayudar a mantener el formato de identacion en el caso que se ocupen los editores la suite de Intellij (ideal comentar la idea) 4.- Error mío, lo arreglaré en el siguiente commit. Muchas gracias por a considerar ayudas por parte de externos para este proyecto universitario! Saludos! |
-Corrected code [canvas.js Line 289 to = instead of ==] -Added .idea folder to .gitignore -Added MailTo link after Swal.Fire
-Fixed Swal.Fire (ok!)
-Fixed some typos -Moved all JS files to /JS/ -Created new way to load "Carreras" on Nav -Templates system! (for code reuse) -Created init.js for reduce recursive code -New way to fetch JS files in parallel and load them asynchronously -Formatted "Prioridad" index.html -Improved "Prioridad" index.html --Script and Style Tags --Changed Nav to NavBar -Fixed .gitignore (sort of)
|
Comment #40 (comment) 2nd point addressed (2/3) |
-Added overflow to canvas (Index.html) -Fixed Some typos (Not my fault)
-Changed relative path to absolute path
-Added Failover in the case of the js files did not load.
-Fixed typos LMAO
-Updated Bootstrap V3 to V4 (Latest)
-Added FontAwesome
-Added SweetAlerts V2
-Added .IDEA
-Formated canvas.js
-Improved canvas.js
--Unterminated statements
--Duplicated declarations
--Line 289 was a condition instead of a comparasion
--Line 293 Changed comparison of any type of var to only the same type as the var to compare (== -> ===)
--Line 318 lineNumber++ * 1 replaced with lineNumber++
-Formatted index.html
-Improved index.html
--Script and Style Tags
--Changed Nav to NavBar
--Changed assureMail() function for use of SweetAlerts
-Formated ramos.js