Fixes get pending when body is provided. #166
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Body is ignored on get (and get-like) operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Identify the Bug
As notified in: #165
The webserver hangs the request without terminating if the request is a body-less one (e.g. GET-like) but provides a body.
Description of the Change
This change allows the webserver to process the request without failing.
Alternate Designs
The linked pull-request presents a design that actively parses and processes the body passed in input. This implementation chooses to discard it instead.
Possible Drawbacks
Main drawback of this choice is not to process the body to adhere to a strict semantic (GET not providing a body). This limits use-cases that might require a body to be provided on GET requests. See motivation in the thread here: #165
Verification Process
Unit and Integration tests
Release Notes
Fixed bug that made the webserver hang the request without terminating if the request was a body-less one (e.g. GET-like) but provided a body.