Some fixes required to build TMLQCD on Daint with libsmear #621
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hi @kostrzewa , I think this PR should now be in a mergeable state. Let me know if you want any further edits! |
|
Have to check compilation / running manually on a few systems for changes which touch the linking. I've found some issues on one machine but I'm not sure if they relate to your changes or simply changes on the machine or previous changes in tmLQCD... Did you run the HMC with this by any chance on some pure CPU machine with QPhiX ? |
|
From what I can see the fact that smearing is built should not actually affect the linking. I think the issue that I'm seeing might be limited to the machine that I'm testing on. Let's merge this and fix it if it breaks somewhere. |
kostrzewa
approved these changes
Feb 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR includes a fix for one compilation issue and turns on the libsmear library with fixes for the various headers to ensure that it builds correctly. This comments out the new(?)
gauge_field_tinterfaces so the library can be build using the old(?)su3_gauge**tuple signatures.See also PR #620