Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hb solver #546

Merged
merged 38 commits into from
Mar 15, 2023
Merged

Hb solver #546

merged 38 commits into from
Mar 15, 2023

Commits on Jul 6, 2022

  1. I am adding a functionality to the HMC. For the CLOVERDETRATIO monomi…

    …al, it's now possible to specify a solver for the heatbath, different from the one used in the MD evolution (computation of the forces).
    
    In order to do that I made the following changes to the code:
    
    1. I added
        `int HB_solver; // solver for the HB only (optional) ` and
        `  solver_params_t HB_solver_params; // parameters of the HB solver ` to the `monomial` struct in `monomial/monomial.h`.
    2. I wrote the declaration `%x HB_MSOLVER` in `read_input.l`. There I also wrote
        `
        {SPC}*HB_Solver{EQL} {
        solver_caller=YY_START;
        BEGIN(NDMSOLVER);
        }
        ` in `<NDRATMONOMIAL,NDRATCORMONOMIAL,NDCLRATMONOMIAL,NDCLRATCORMONOMIAL,NDDETRATMONOMIAL,NDCLDETRATMONOMIAL>`,
        which
        I defined the block `<HB_MSOLVER>`, analogously to `<MSOLVER>`, replacing all the occurrencies of `mnl->solver =` with `mnl->HB_solver =`.
        ** To do**: do the same with the solver_parameters
    3. I added `INVALID_SOLVER` to the `SOLVER_TYPE` enum in `solver/solver_type.h`. It's value is `26`.
    4. I added the macro `#define _default_HB_solver_flag 26 // this is INVALID_SOLVER (see solver/solver_types.h)` in `default_input_values.h`.
    5. In `monomial/cloverdetratio_monomial.c` I changed the function `cloverdetratio_heatbath()` replacing all the occurrencies of `mnl->solver` and `mnl->solver_params` with `mnl->HB_solver` and `mnl->HB_solver_params` respectively.
    6. In `monomial/monomial.c`:
        - In `add_monomial()`, I added
        `monomial_list[no_monomials].HB_solver = _default_HB_solver_flag;` in the function `add_monomial()`.
        - In `init_monomials()`, when the HB solver is invalid, i.e. `(monomial_list[i].HB_solver == INVALID_SOLVER`, I set the `HB_solver` and ` Hb_solver_params` equal to the ones used in the MD evolution. In short: if the HB solver is not specified in the input file, the solver type and its parameters are copied from what was specified for the MD. (note that the `hbfunction` is the same, but now uses the HB solver and its parameters)
    simone-romiti committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    9640a58 View commit details
    Browse the repository at this point in the history
  2. In read_input.l, I added the block

    `<DETMONOMIAL,CLDETMONOMIAL,CLDETRATMONOMIAL,CLDETRATRWMONOMIAL,NDRATMONOMIAL,NDRATCORMONOMIAL,NDCLRATMONOMIAL,NDCLRATCORMONOMIAL,RATMONOMIAL,RATCORMONOMIAL,CLRATMONOMIAL,CLRATCORMONOMIAL,NDDETRATMONOMIAL,NDCLDETRATMONOMIAL>`
    which parses, for each monomial `mnl`, the `HB_solver_params` attributes.
    I did it by copying and pasting the same block for `mnl->solver_params` and preplacing those occurrences with `mnl->HB_solver_params`.
    Note that the default values don't need to be specified because the default corresponds to the solver used in the MD evolution.
    simone-romiti committed Jul 6, 2022
    Configuration menu
    Copy the full SHA
    7cdddf5 View commit details
    Browse the repository at this point in the history

Commits on Jul 8, 2022

  1. In monomial/detratio_monomial.c I changed the function `detratio_he…

    …atbath()` replacing all the occurrencies of `mnl->solver` and `mnl->solver_params` with `mnl->HB_solver` and `mnl->HB_solver_params` respectively.
    simone-romiti committed Jul 8, 2022
    Configuration menu
    Copy the full SHA
    40482d0 View commit details
    Browse the repository at this point in the history

Commits on Jul 12, 2022

  1. Reply to #546 (comment). I've prepended HB_ to the parsing strings:

    `HB_UseExternalInverter, HB_UseSloppyPrecision, HB_UseCompression`
    simone-romiti committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    c39d63e View commit details
    Browse the repository at this point in the history
  2. Reply to #546 (comment). I removed the block

    `
    {SPC}*HB_Solver{EQL} {
    solver_caller=YY_START;
    BEGIN(NDMSOLVER);
    `
    We don't need to be able to set the HB solver also for the ND monomial.
    simone-romiti committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    327f2d8 View commit details
    Browse the repository at this point in the history
  3. Reply to #546 (comment). I've added the default initialization of the…

    … HB_solver also for the DETRATIO monomial.
    simone-romiti committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    860e5ad View commit details
    Browse the repository at this point in the history
  4. modified: read_input.l

    HB_solver specified only for the cloverdetratio and detratio monomials
    simone-romiti committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    2534c6c View commit details
    Browse the repository at this point in the history
  5. - declaration of DETRATIO

    - Removed extra spaces in blockS (flex syntax error)
    	modified:   read_input.l
    Simone Romiti committed Jul 12, 2022
    Configuration menu
    Copy the full SHA
    141c9a6 View commit details
    Browse the repository at this point in the history

Commits on Jul 13, 2022

  1. add HB_maxiter

    simone-romiti committed Jul 13, 2022
    Configuration menu
    Copy the full SHA
    3cf0922 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7438daa View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    d0d772d View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    5bccf10 View commit details
    Browse the repository at this point in the history
  5. Configuration menu
    Copy the full SHA
    0d14fc4 View commit details
    Browse the repository at this point in the history

Commits on Jul 14, 2022

  1. DDalphaAMG as HB solver

    Marcogarofalo committed Jul 14, 2022
    Configuration menu
    Copy the full SHA
    cc5292a View commit details
    Browse the repository at this point in the history

Commits on Nov 2, 2022

  1. Configuration menu
    Copy the full SHA
    4f02cc5 View commit details
    Browse the repository at this point in the history

Commits on Dec 16, 2022

  1. Configuration menu
    Copy the full SHA
    23f7f54 View commit details
    Browse the repository at this point in the history
  2. 1 Configuration menu
    Copy the full SHA
    ff57999 View commit details
    Browse the repository at this point in the history
  3. see ff57999#r93305534

    simone-romiti committed Dec 16, 2022
    Configuration menu
    Copy the full SHA
    0cc0336 View commit details
    Browse the repository at this point in the history

Commits on Jan 11, 2023

  1. Configuration menu
    Copy the full SHA
    c330493 View commit details
    Browse the repository at this point in the history
  2. typo in basic-build.yaml

    kostrzewa committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    7786c3e View commit details
    Browse the repository at this point in the history
  3. Configuration menu
    Copy the full SHA
    ee1c4e1 View commit details
    Browse the repository at this point in the history
  4. Configuration menu
    Copy the full SHA
    8854044 View commit details
    Browse the repository at this point in the history
  5. with: is required

    kostrzewa committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    41a9916 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    81a9c80 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    704b891 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    b855787 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    bcf6cfb View commit details
    Browse the repository at this point in the history
  10. apparently the OpenMPI package does not ship with libmpi any more, th…

    …ere's a separate lib file now
    kostrzewa committed Jan 11, 2023
    Configuration menu
    Copy the full SHA
    1d05e28 View commit details
    Browse the repository at this point in the history
  11. Configuration menu
    Copy the full SHA
    ad2738b View commit details
    Browse the repository at this point in the history
  12. Configuration menu
    Copy the full SHA
    fe1d38b View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2023

  1. Configuration menu
    Copy the full SHA
    bd9e369 View commit details
    Browse the repository at this point in the history

Commits on Feb 2, 2023

  1. Configuration menu
    Copy the full SHA
    5c25216 View commit details
    Browse the repository at this point in the history
  2. Configuration menu
    Copy the full SHA
    7f65fe9 View commit details
    Browse the repository at this point in the history

Commits on Feb 3, 2023

  1. Configuration menu
    Copy the full SHA
    10989e0 View commit details
    Browse the repository at this point in the history

Commits on Feb 4, 2023

  1. Configuration menu
    Copy the full SHA
    fadcbc1 View commit details
    Browse the repository at this point in the history

Commits on Mar 1, 2023

  1. Configuration menu
    Copy the full SHA
    d8a7d38 View commit details
    Browse the repository at this point in the history

Commits on Mar 2, 2023

  1. Configuration menu
    Copy the full SHA
    d24e5ce View commit details
    Browse the repository at this point in the history

Commits on Mar 15, 2023

  1. Configuration menu
    Copy the full SHA
    ac9349e View commit details
    Browse the repository at this point in the history