Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port mav_msgs to ROS 2 #90

Merged
merged 1 commit into from
Nov 17, 2023

Conversation

srmainwaring
Copy link

@srmainwaring srmainwaring commented Nov 7, 2023

This is a port of mav_comm to ROS 2, required for a downstream port of terrain-navigation.

@Jaeyoung-Lim could you please create a ros2 branch and I'll update the PR to target that.

Related

@srmainwaring srmainwaring changed the base branch from master to ros2 November 7, 2023 15:43
@Jaeyoung-Lim
Copy link
Member

@Jaeyoung-Lim could you please create a ros2 branch and I'll update the PR to target that.

Done!

@srmainwaring
Copy link
Author

srmainwaring commented Nov 15, 2023

Done!

Thanks @Jaeyoung-Lim. I don't have access to the Jenkins job to see what needs resolving / updating for CI. Probably need a ROS 2 enabled machine but I can't tell from the info in the repo.

Let me know what you'd like completed to get this merged as it's a pre-requisite for the terrain-navigation port. It's not too much work at this stage to complete the port for the remaining packages if that is preferred.

Update: 17 Nov

@Jaeyoung-Lim - I've converted the remaining packages / msgs to ROS 2 and squashed everything down to a single commit. If you are ok with changes could you please approve and merge into the ros2 branch.

- Port mav_msgs to ros2 humble

Signed-off-by: Rhys Mainwaring <[email protected]>

- Update additional includes.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Update conversions and package deps.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Update package and cmake files.

Signed-off-by: Rhys Mainwaring <[email protected]>

- Port mav_planning_msgs to ros2 humble

Signed-off-by: Rhys Mainwaring <[email protected]>

- Port mav_state_machine_msgs to ros2 humble

Signed-off-by: Rhys Mainwaring <[email protected]>

- Port mav_system_msgs to ros2 humble

Signed-off-by: Rhys Mainwaring <[email protected]>

- Port meta-package mav_comm to ros2 humble

Signed-off-by: Rhys Mainwaring <[email protected]>
@Jaeyoung-Lim Jaeyoung-Lim merged commit 37547f0 into ethz-asl:ros2 Nov 17, 2023
1 check failed
@srmainwaring srmainwaring deleted the prs/pr-ros2-humble branch November 17, 2023 14:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants