Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixed LOG_TIMED and ROS_INFO_THROTTLE macros in MODE_GLOG #27

Merged
merged 11 commits into from
Apr 17, 2024
Merged

Fixed LOG_TIMED and ROS_INFO_THROTTLE macros in MODE_GLOG #27

merged 11 commits into from
Apr 17, 2024

Conversation

4c3y
Copy link
Member

@4c3y 4c3y commented Apr 4, 2024 •
edited
Loading

@4c3y 4c3y added the bug Something isn't working label Apr 4, 2024
@4c3y 4c3y linked an issue Apr 5, 2024 that may be closed by this pull request
LOG_TIMED does not support floating point numbers #24
Closed
@4c3y 4c3y requested a review from michaelpantic April 9, 2024 09:26
@4c3y 4c3y marked this pull request as ready for review April 9, 2024 09:26
michaelpantic
michaelpantic approved these changes Apr 17, 2024
View reviewed changes
Copy link
Member

@michaelpantic michaelpantic left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, see minor comments. Can be merged once fixed (if it needs fixing).
Thanks!

include/log++.h Show resolved Hide resolved
include/log++.h Outdated Show resolved Hide resolved
@4c3y 4c3y merged commit b190abd into master Apr 17, 2024
13 checks passed
@4c3y 4c3y deleted the fix/timed-logging branch April 17, 2024 16:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@michaelpantic michaelpantic michaelpantic approved these changes

Assignees
No one assigned
Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Compile error with timed logging functions LOG_TIMED does not support floating point numbers
2 participants
@4c3y @michaelpantic