-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Incrementally loading terrain from VRT server #63
Conversation
cc0f3f4
to
1740b98
Compare
20c7a7f
to
0ebc1d9
Compare
2e4fb1c
to
83b8292
Compare
Use gdal transforms Remove geoconversion library F F
83b8292
to
787288e
Compare
auto cell_position_lv03 = cell_position + query_position_lv03.head(2); // Position of cell in CH1903/LV03 | ||
double dummy; | ||
Eigen::Vector2d cell_position_wgs84; | ||
transformCoordinates(ESPG_CH1903_LV03, cell_position_lv03(0), cell_position_lv03(1), cell_position_lv03(2), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rather than transform individual coordinates, do you think doing a warp operation in gdal
would lead to higher performance?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@Ryanf55 Definitely, but not sure how we can do this within the cpp API. Do you have any ideas on how to do it with a vrt? Or should we do it after copying over?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice!
Merging as is for now, improvements can be made in a follow up PR |
Sounds good. I need to figure out warping soon because I need cartesian terrain grid maps from non-cartesian sources. |
* Add vrt parsing node * Load position and extent from VRT server F * Add terrain loader node Use gdal transforms Remove geoconversion library F F * Update readme
* Add vrt parsing node * Load position and extent from VRT server * Add terrain loader node * Use gdal transforms * Remove geoconversion library * Update readme
Problem Description
This PR adds a terrain loading node to load a terrain from a VRT server, instead of loading from a tif file.
The biggest difference is that I have separated out the vrt loading function from normal tif loading.
Note