Incrementally loading terrain from VRT server #63
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jaeyoung-Lim
force-pushed
the
pr-vrt-ros1
branch
from
cc0f3f4
to
1740b98
Compare
Jaeyoung-Lim
changed the title
Jaeyoung-Lim
force-pushed
the
pr-vrt-ros1
branch
3 times, most recently
from
20c7a7f
to
0ebc1d9
Compare
Jaeyoung-Lim
force-pushed
the
pr-vrt-ros1
branch
2 times, most recently
from
2e4fb1c
to
83b8292
Compare
Use gdal transforms Remove geoconversion library F F
Jaeyoung-Lim
force-pushed
the
pr-vrt-ros1
branch
from
83b8292
to
787288e
Compare
Ryanf55
reviewed
Apr 15, 2024
| auto cell_position_lv03 = cell_position + query_position_lv03.head(2); // Position of cell in CH1903/LV03 | ||
| double dummy; | ||
| Eigen::Vector2d cell_position_wgs84; | ||
| transformCoordinates(ESPG_CH1903_LV03, cell_position_lv03(0), cell_position_lv03(1), cell_position_lv03(2), |
There was a problem hiding this comment.
Rather than transform individual coordinates, do you think doing a warp operation in gdal would lead to higher performance?
There was a problem hiding this comment.
@Ryanf55 Definitely, but not sure how we can do this within the cpp API. Do you have any ideas on how to do it with a vrt? Or should we do it after copying over?
|
Merging as is for now, improvements can be made in a follow up PR |
|
Sounds good. I need to figure out warping soon because I need cartesian terrain grid maps from non-cartesian sources. |
Jaeyoung-Lim
added a commit
that referenced
this pull request
Aug 25, 2024
* Add vrt parsing node * Load position and extent from VRT server F * Add terrain loader node Use gdal transforms Remove geoconversion library F F * Update readme
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem Description
This PR adds a terrain loading node to load a terrain from a VRT server, instead of loading from a tif file.
The biggest difference is that I have separated out the vrt loading function from normal tif loading.
Note