CI: Split docs workflows and add write permissions for pages deployment #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ryan Friedman <[email protected]>
* Build runs like normal without the deploy * Deploy only runs on the ros2 branch * Reused workflows: https://docs.github.com/en/actions/using-workflows/reusing-workflows Signed-off-by: Ryan Friedman <[email protected]>
* And remove tokens since the repo is now public Signed-off-by: Ryan Friedman <[email protected]>
Ryanf55
changed the title
Jaeyoung-Lim
approved these changes
Jan 18, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an attempted fix for #51. Oh yea, and rename the job to be correct.
Edit: Doh - no dice: https://github.com/ethz-asl/grid_map_geo/actions/runs/7565414848/job/20601127489?pr=52#step:5:145
The docs for
peaceiris/actions-gh-pagesdo not seem suffient, and the other repo-wide permissions change is a security risk.The approach here is to split the jobs, and only try deploying on
ros2after it's merged. Might breakros2branch, and if it does, we'll just remove pages deploy and find another approach.