-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Port to humble #24
Port to humble #24
Conversation
@Ryanf55 Could you switch the base branch of the PR to |
Done! I'll have to fix merge conflicts now, but it should give you the basic idea. |
Signed-off-by: Ryan Friedman <[email protected]>
f12bf51
to
49f3ef0
Compare
* Update docs * Remove ROS1 cruft Signed-off-by: Ryan Friedman <[email protected]>
49f3ef0
to
d84b2b2
Compare
I've fixed merge conflicts. Ready for review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome! Thanks! Looks good for me!
Realized that the build test of ROS Noetic should not be valid for this branch anymore. Will address in a follow up PR @Ryanf55 Should we make the ros2 branch the default? or would you prefer a separate repository? I can also create a |
I've generally seen just updating |
This has all the changes I made to port to humble. This duplicates other work, however there are unique pieces that can be covered.