Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA 151 #5682

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

LA 151 #5682

wants to merge 1 commit into from

Conversation

Vagoasdf
Copy link
Contributor

We are updating mongodb to be able to parse special char
Closes []

Description Of Changes

Write some things here about the changes and any potential caveats

Code Changes

  • list your code changes here

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
    • Add a db-migration This indicates that a change includes a database migration label to the entry if your change includes a DB migration
    • Add a high-risk This issue suggests changes that have a high-probability of breaking existing code label to the entry if your change includes a high-risk change (i.e. potential for performance impact or unexpected regression) that should be flagged
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@Vagoasdf
base fix for the connector, use urllib
b8e940c 
We would be able to parse the special url chars
@vercel Vercel
Copy link

vercel bot commented Jan 17, 2025

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Jan 17, 2025 8:43pm

@cypress Cypress
Copy link

cypress bot commented Jan 17, 2025

fides    Run #11840

Run Properties:  status check failed Failed #11840  •  git commit 1bc971b3bc ℹ️: Merge b8e940ce1dbb67dc46987f1f3c192ef969f0f12c into fdd8b4bcbaf910f4d5bc5b979d28...
Project fides
Branch Review refs/pull/5682/merge
Run status status check failed Failed #11840
Run duration 01m 53s
Commit git commit 1bc971b3bc ℹ️: Merge b8e940ce1dbb67dc46987f1f3c192ef969f0f12c into fdd8b4bcbaf910f4d5bc5b979d28...
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎
Test results
Tests that failed  Failures 2
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 2
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Tests for review

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Vagoasdf