Migrate radio buttons to Ant Design #5681
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5681/merge
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | jpople |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
jpople
commented
Jan 17, 2025
| { | ||
| // console.log(system); | ||
| return <Flex> </Flex>; | ||
| }; |
There was a problem hiding this comment.
Just commenting this out for now to make ESLint happy for CI purposes.
jpople
changed the title
gilluminate
approved these changes
Jan 17, 2025
| <FormControl isInvalid={isInvalid}> | ||
| <Flex className="w-fit"> | ||
| {label ? ( | ||
| <Label htmlFor={props.id || props.name}>{label}</Label> |
There was a problem hiding this comment.
This label doesn't actually tie to any form elements, so we should just leave off the htmlFor altogether. It's mostly a decorative label.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes HJ-223
Description Of Changes
Migrates radio buttons and radio groups to Ant Design.
Code Changes
inputs.tsxto its own fileSteps to Confirm
Test the radio buttons on the following pages and verify they look correct and work as intended:
/privacy-requests/configuration/messaging/privacy-requests/configuration/storagePre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works