Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

empty commit to start release 2.53.0 #5679

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -39,6 +39,7 @@ Changes can also be flagged with a GitHub label for tracking purposes. The URL o
- Updated `DBCache` model so setting cache value always updates the updated_at field [#5669](https://github.com/ethyca/fides/pull/5669)
- Changed sizes of buttons in table headers [#5654](https://github.com/ethyca/fides/pull/5654)
- Adds new config for max number of rows in DSR download through Admin-UI [#5671](https://github.com/ethyca/fides/pull/5671)
- Added CSS variable to FidesJS: `--fides-base-font-size: 16px` for better consistency. Overriding this variable with "1rem" will mimic legacy behavior. [#5673](https://github.com/ethyca/fides/pull/5673) https://github.com/ethyca/fides/labels/high-risk

### Fixed
- Fixed issue where the custom report "reset" button was not working as expected [#5649](https://github.com/ethyca/fides/pull/5649)
Expand Down
26 changes: 12 additions & 14 deletions clients/fides-js/src/components/fides.css
Original file line number Diff line number Diff line change
Expand Up @@ -56,11 +56,11 @@

/* Everything else */
--fides-overlay-font-family: Inter, sans-serif;
--8px: 0.5rem;
--12px: 0.75rem;
--14px: 0.875rem;
--15px: 0.9375rem;
--16px: 1rem;
--fides-base-font-size: 16px;
--8px: calc(var(--fides-base-font-size) * 0.5);
--12px: calc(var(--fides-base-font-size) * 0.75);
--14px: calc(var(--fides-base-font-size) * 0.875);
--16px: calc(var(--fides-base-font-size) * 1);
--fides-overlay-font-size-body-xs: var(--8px);
--fides-overlay-font-size-body-small: var(--12px);
--fides-overlay-font-size-body: var(--14px);
Expand Down Expand Up @@ -115,9 +115,7 @@ div#fides-overlay-wrapper * {
font-family: var(--fides-overlay-font-family);
font-size: var(--fides-overlay-font-size-body);
white-space: pre-line;

/* CSS reset values, adapted from https://www.joshwcomeau.com/css/custom-css-reset/ */
line-height: calc(1em + 0.4rem);
line-height: 1.4em;
-webkit-font-smoothing: antialiased;
}

Expand Down Expand Up @@ -737,7 +735,7 @@ div#fides-overlay-wrapper .fides-toggle .fides-toggle-display {
display: inline-block;
min-width: 8px;
height: 8px;
margin-right: calc(0.5rem + 2px);
margin-right: calc(var(--8px) + 2px); /* half font size + border width */
content: "";
transition: transform 0.12s ease-in-out;
transform: translateY(-2px) rotate(135deg);
Expand Down Expand Up @@ -1065,7 +1063,7 @@ div#fides-overlay-wrapper .fides-i18n-pseudo-button {
display: flex;
flex-direction: column;
gap: 1px;
max-height: 7rem;
max-height: calc(var(--fides-base-font-size) * 7);
transition: height 0.5s;
}

Expand All @@ -1079,7 +1077,7 @@ div#fides-overlay-wrapper .fides-i18n-pseudo-button {

.fides-i18n-menu:hover .fides-i18n-popover,
.fides-i18n-menu:focus-within .fides-i18n-popover {
min-width: 9rem;
min-width: calc(var(--fides-base-font-size) * 9);
height: auto;
border: 1px solid var(--fides-overlay-primary-color);
background-color: var(--fides-overlay-background-dark-color);
Expand All @@ -1095,7 +1093,7 @@ button.fides-banner-button.fides-menu-item {
width: 100%;
text-align: left;
margin: 0;
padding-left: 1.5rem;
padding-left: calc(var(--fides-base-font-size) * 1.5);
}

button.fides-banner-button.fides-menu-item[aria-pressed="true"] {
Expand All @@ -1106,8 +1104,8 @@ button.fides-banner-button.fides-menu-item[aria-pressed="true"] {
button.fides-banner-button.fides-menu-item[aria-pressed="true"]::before {
content: "\2713";
display: inline-block;
margin-right: 0.25rem;
margin-left: -1rem;
margin-right: calc(var(--fides-base-font-size) * 0.25);
margin-left: calc(var(--fides-base-font-size) * -1);
}

button.fides-banner-button.fides-menu-item:not([aria-pressed="true"]):hover {
Expand Down
Loading