HJ 181 - Datahub groundwork and UI #5666
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5666/merge
|
| Run status |
|
| Run duration | 00m 50s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5666 +/- ##
==========================================
+ Coverage 84.94% 87.13% +2.19%
==========================================
Files 388 388
Lines 24014 24018 +4
Branches 2593 2593
==========================================
+ Hits 20399 20929 +530
+ Misses 3051 2528 -523
+ Partials 564 561 -3 ☔ View full report in Codecov by Sentry. |
andres-torres-marroquin
changed the title
erosselli
reviewed
Jan 14, 2025
clients/admin-ui/src/features/integrations/integration-type-info/datahubInfo.tsx
Outdated
Show resolved
Hide resolved
clients/admin-ui/src/features/integrations/integration-type-info/datahubInfo.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: erosselli <[email protected]>
| @@ -147,7 +147,15 @@ def test_connection_type_human_readable(self): | |||
|
|
|||
| def test_connection_type_human_readable_invalid(self): | |||
| with pytest.raises(ValueError): | |||
| ConnectionType("nonmapped_type").human_readable() | |||
| ConnectionType("nonmapped_type").human_readable | |||
There was a problem hiding this comment.
human_readable is a property not a method
erosselli
approved these changes
Jan 15, 2025
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 57s |
| Commit |
|
| Committer | Andres Torres |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #HJ-181
Description Of Changes
Datahub should be in fidesplus
Code Changes
SystemTypeenumDatahubSchema.frequency, it is going to be added back on the new type of monitorDatahubSchema.frequencySteps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdatedmaindowngrade()migration is correct and works