LA-56 Only trigger dataset save if values have changed (#5612)

Co-authored-by: Lucano Vera <[email protected]>
ethyca · Dec 17, 2024 · 70272d1 · 70272d1
1 parent 937e713
commit 70272d1
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 2 deletions.
diff --git a/CHANGELOG.md b/CHANGELOG.md
@@ -30,6 +30,7 @@ The types of changes are:
 
 ### Fixed
 - Fixing quickstart.py script [#5585](https://github.com/ethyca/fides/pull/5585)
+- Removed unnecessary double notification when updating database integrations [#5612](https://github.com/ethyca/fides/pull/5612)
 
 ## [2.51.2](https://github.com/ethyca/fides/compare/2.51.1...2.51.2)
 

diff --git a/...-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParameters.tsx b/...-ui/src/features/datastore-connections/system_portal_config/forms/ConnectorParameters.tsx
@@ -295,7 +295,9 @@ export const useConnectorForm = ({
         values.dataset &&
         connectionOption.type === SystemType.DATABASE
       ) {
-        await patchConnectionDatasetConfig(values, connectionConfig.key);
+        await patchConnectionDatasetConfig(values, connectionConfig.key, {
+          showSuccessAlert: false,
+        });
       }
 
       successAlert(

diff --git a/...onnections/system_portal_config/forms/fields/DatasetConfigField/useDatasetConfigField.tsx b/...onnections/system_portal_config/forms/fields/DatasetConfigField/useDatasetConfigField.tsx
@@ -50,6 +50,7 @@ export const useDatasetConfigField = ({
   const patchConnectionDatasetConfig = async (
     values: ConnectionConfigFormValues,
     connectionConfigKey: string,
+    { showSuccessAlert = true }: { showSuccessAlert?: boolean } = {},
   ) => {
     const newDatasetPairs: DatasetConfigCtlDataset[] =
       values.dataset?.map((datasetKey) => ({
@@ -65,7 +66,7 @@ export const useDatasetConfigField = ({
     const payload = await putDatasetConfig(params).unwrap();
     if (payload.failed?.length > 0) {
       errorAlert(payload.failed[0].message);
-    } else {
+    } else if (showSuccessAlert) {
       successAlert("Dataset successfully updated!");
     }
   };