Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(op-challenger): add EventCall, TxCall and GetSubClaims #63

Closed
wants to merge 7 commits into from

Conversation

dajuguan
Copy link

@dajuguan dajuguan commented Sep 27, 2024

We aim to address the issue of performing an attack transaction on a disputed claim by introducing a feature to decode the claims from calldata/blob in the FaultDisputeGameN.sol contract. The purpose of this feature is to allow the challenger to assess the validity of the claim and decide whether to initiate an attack.

  • Implement LogFilterer(FilterLogs and SubscribeFilterLogs func) interface for MultiCaller to stub Event log response
  • Implement Call (ToBatchElemCreator and HandleResult func) interface for TxCall and EventCall to support eth_getTransactionByHash and eth_getFilterLogs RPCs
  • Add event_stub.go and tx_stub.go to support mocking RPC tests
  • Add GetSubClaims function to retrieve subClaims from callData(done) and blobs(todo)

op-challenger/game/fault/contracts/faultdisputegame.go Outdated Show resolved Hide resolved
op-service/sources/batching/tx_call.go Outdated Show resolved Hide resolved
op-service/sources/batching/bound.go Outdated Show resolved Hide resolved
@blockchaindevsh
Copy link

Is there an overall description for this PR instead of implementation details?

@dajuguan
Copy link
Author

dajuguan commented Oct 9, 2024

Is there an overall description for this PR instead of implementation details?

Description added

@blockchaindevsh
Copy link

blockchaindevsh commented Oct 10, 2024

Is there an overall description for this PR instead of implementation details?

Description added

I may lack some context, but from the point of view of OP, it seems still quite hard to understand the rationale of the changes from the description alone, which is important if you want it to be accepted by upstream.

@dajuguan
Copy link
Author

Is there an overall description for this PR instead of implementation details?

Description added

I may lack some context, but from the point of view of OP, it seems still quite hard to understand the rationale of the changes from the description alone, which is important if you want it to be accepted by upstream.

Great, taking another look and rethinking the rationale sounds like a good approach. A clearer explanation will definitely help with upstream acceptance.

@dajuguan dajuguan changed the title Feat: add EventCall, TxCall and GetSubClaims feat(op-challenger): add EventCall, TxCall and GetSubClaims Oct 20, 2024
@dajuguan
Copy link
Author

Anymore comments? Are we good to merge?

@dajuguan
Copy link
Author

dajuguan commented Nov 3, 2024

deprecated in #84

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants