fix: handling of config options #85
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
onbjerg
added a commit
to ithacaxyz/odyssey
that referenced
this pull request
Oct 19, 2024
Uses ethpandaops/optimism-package#85 for now, once merged can be replaced with upstream package. This also switches to using images from https://github.com/paradigmxyz/optimism cc @Rjected --------- Co-authored-by: Oliver <[email protected]>
|
@barnabasbusa this should be good to merge I think? |
barnabasbusa
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds 2 configuration options and fixes handling of existing ones:
fund_dev_accountsoption is added tonetwork_params, allowing to configure whether dev accounts should be funded on L2. In one of recent updates they stopped being funded by default, this PR changes it, let me know if this is undesiredbatcher_imageoption allowing to configure custom op-batcher imageel_extra_params, right now this argument is not respectedseconds_per_slot, right now this argument is not respectedAlso it seems that
countkey for participants is no more respected. Is this intentional?