-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: viem migration #34
Open
kanthgithub
wants to merge
27
commits into
master
Choose a base branch
from
feature/viem-migration
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kanthgithub
requested review from
arddluma,
vignesha22,
ch4r10t33r and
nikhilkumar1612
August 19, 2024 17:57
…le, rotate sessionkey functions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Migrate etherspot-modular-sdk from
ethers
toviem
Description
viem
dependency added topackage.json
ModularSDK
,EtherSpotWalletAPI
and dependant typescript classes are refactored toviem
account,PublicClient
,WalletClient
privateKey
to SDK initialisationBigNumber
,UserOpsStructs
etherspot-module-contracts
modular-contracts
being used in SDKManual Testing
Test Strategy:
Key functions of the Modular Smartcontracts:
Example scripts in the directory: are used to test above set of scenarios
The SDK function path will cove most of the migrated set of functions while testing above list of scenarios
Test Networks
Scenarios are tested on
Sepolia
andAmoy
Test Proofs
Transfer ERC20 tokens
get Counterfactual Address
get Gas Fees
get Nonce
Transfer ERC20
Transfer Funds
List Modules
Uninstall Module
0xF4CDE8B11500ca9Ea108c5838DD26Ff1a4257a0c
0xF4CDE8B11500ca9Ea108c5838DD26Ff1a4257a0c
0xF4CDE8B11500ca9Ea108c5838DD26Ff1a4257a0c
Install Module
0x22A55192a663591586241D42E603221eac49ed09
0x22A55192a663591586241D42E603221eac49ed09
0x22A55192a663591586241D42E603221eac49ed09
0xF4CDE8B11500ca9Ea108c5838DD26Ff1a4257a0c
0xF4CDE8B11500ca9Ea108c5838DD26Ff1a4257a0c
Enable SessionKey
ERC20SessionKeyValidator
Rotate SessionKey
enableSessionKey
Disable SessionKey
Enable new SessionKey & Token Transfer via new SessionKey
Types of changes