Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: stewardship with erasure encoding #4955

Merged
merged 5 commits into from
Feb 4, 2025
Merged

Conversation

acha-bill
Copy link
Contributor

@acha-bill acha-bill commented Jan 23, 2025

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

When iterating over chunks, parity chunks were incorrectly attempted to be fetched from the redundancy getter, which only supports shards.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

closes #4948

Screenshots (if appropriate):

@acha-bill acha-bill requested a review from martinconic January 30, 2025 06:13
@acha-bill acha-bill changed the title test: stewardship with erasure encoding fix: stewardship with erasure encoding Jan 30, 2025
@acha-bill acha-bill marked this pull request as ready for review January 30, 2025 06:13
@acha-bill acha-bill requested a review from istae as a code owner January 30, 2025 06:13
pkg/file/joiner/joiner.go Outdated Show resolved Hide resolved
@acha-bill acha-bill requested a review from istae February 3, 2025 14:19
@istae
Copy link
Member

istae commented Feb 4, 2025

Merging this now, a fix for #4977 will be included in a different PR

@istae istae merged commit cda61e5 into master Feb 4, 2025
15 checks passed
@istae istae deleted the feat/stewardship-erasure-coding branch February 4, 2025 10:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

erasure coding stewardship endpoint returns false
2 participants