fix: chunkstamp load with hash, replace to increase refCnt, new soc eviction unit test, index collision check changes #4900
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nugaon
force-pushed
the
feat/gsoc-subscribe
branch
from
a21c988
to
8c416af
Compare
istae
changed the title
istae
force-pushed
the
fix-chunkstamp
branch
from
17aa920
to
f2056a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
wrote a new reserve eviction test for SOCs.
fixed:
chunkstamp expects that the chunk address and batch id are unique entries
anywhere we use chunkstamp.LoadWithBatchID, we can't reliably tell it's the correct stamp
i wrote a unit test that uploads 10 gsoc chunks and the chunkstamp.LoadWithBatchID was an issue
the chunkstore.Replace is also supposed to increment the refCnt as each SOC creates a new reserve entry.
fixed index collision checks
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):