Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

style: add some missing words. #917

Merged
merged 3 commits into from
Sep 2, 2024
Merged

style: add some missing words. #917

merged 3 commits into from
Sep 2, 2024

Conversation

blablalf
Copy link
Contributor

@blablalf blablalf commented Aug 29, 2024 •
edited
Loading

Hello, while reading the paper, I noticed a few small typos. Here is a fix if you want it.

  • The phrase "must at least as high as" should be corrected to "must be at least as high as.".
  • The phrase "Gtxcreate is added if the transaction is contractcreating, but not if a result of EVM-code." should be "Gtxcreate is added if the transaction is contractcreating, but not if it is a result of EVM-code.".

@blablalf blablalf changed the title style: add a missing "be". style: add some missing words. Aug 29, 2024
yperbasis
yperbasis requested changes Aug 30, 2024
View reviewed changes
Copy link
Member

@yperbasis yperbasis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The original text is confusing/incorrect. It should say something like "but not if it is a message call" instead.

@blablalf
Copy link
Contributor Author

but not if it is a message call

I thought the sentence you recommended was clear, so I simply commited it as it was.

@yperbasis yperbasis merged commit 9fde3f4 into ethereum:master Sep 2, 2024
1 check passed
fulldecent pushed a commit to fulldecent/yellowpaper that referenced this pull request Dec 31, 2024
@blablalf @fulldecent
style: add some missing words. (ethereum#917)
d3b5993 
* style: add a missing "be".

* style: add a missing "it is".

* refactor: clearer sentence
yperbasis pushed a commit that referenced this pull request Jan 16, 2025
@pldespaigne @blablalf
@stehled @raxhvl
Update cancun branch with latest changes from master (#922)
9737b2b 
* style: add some missing words. (#917)

* style: add a missing "be".

* style: add a missing "it is".

* refactor: clearer sentence

* Fix transactions typo (#919)

* 🐞 fix: Formula for initcode limit (#920)

Co-authored-by: rahul <[email protected]>

---------

Co-authored-by: Alfred Gaillard <[email protected]>
Co-authored-by: stehled <[email protected]>
Co-authored-by: raxhvl <[email protected]>
Co-authored-by: rahul <[email protected]>
yperbasis pushed a commit that referenced this pull request Feb 26, 2025
@pldespaigne @blablalf
@stehled @raxhvl
CANCUN: EIP-1153 Transient Storage (#916)
fc185c5 
* style: add some missing words. (#917)

* style: add a missing "be".

* style: add a missing "it is".

* refactor: clearer sentence

* Fix transactions typo (#919)

* 🐞 fix: Formula for initcode limit (#920)

Co-authored-by: rahul <[email protected]>

* transient storage

* simpler definition

* use Gwarmaccess for transient costs

* Xi theta return order

* typo

---------

Co-authored-by: Alfred Gaillard <[email protected]>
Co-authored-by: stehled <[email protected]>
Co-authored-by: raxhvl <[email protected]>
Co-authored-by: rahul <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@yperbasis yperbasis yperbasis approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@blablalf @yperbasis