Shanghai Update #906

pldespaigne · 2024-04-30T17:07:20Z

Update the Yellow Paper from the Paris hard-fork to the Shanghai hard-fork.

EIP-3651: Warm COINBASE
EIP-3855: PUSH0 instruction
EIP-3860: Limit and meter initcode
EIP-4895: Beacon chain push withdrawals as operations
EIP-6049: Deprecate SELFDESTRUCT
General Updates

Here is the current pdf version of the Yellow Paper for this PR.

EIP-3651: Warm COINBASE

View Screenshot Diff

Before	After

EIP-3855: PUSH0 instruction

View Screenshot Diff

Before	After

EIP-3860: Limit and meter initcode

View Screenshot Diff

Before	After

EIP-4895: Beacon chain push withdrawals as operations

View Screenshot Diff

Before	After

EIP-6049: Deprecate SELFDESTRUCT

View Screenshot Diff

Before	After

General Updates

commit changes
review → changes: 878ee5b

View Screenshot Diff

Before	After

pldespaigne · 2024-05-07T12:45:58Z

Bump @yperbasis @timbeiko
Let me know, if you need more detail on the PR changes, or anything else!

yperbasis · 2024-05-09T09:12:22Z

Bump @yperbasis @timbeiko Let me know, if you need more detail on the PR changes, or anything else!

Currently I don't have the capacity to review this PR unfortunately :(

pldespaigne · 2024-05-10T08:44:00Z

@yperbasis
I understand, do you know of anyone that could have a look at this?
Should I try to bring some non-maintainer peoples in the convo to give feedback on my changes?
I've signed a grant agreement with the EF to update the YP to Shanghai & Cancun, that's why I'll try to help you as much as I can to merge this.

alexprut · 2024-05-10T09:35:14Z

@pldespaigne not a maintainer, nor fully up to date with all the protocol changes, contributed (small) changes years ago.

However, the work you are doing is interesting, if it's helpful I can spend a spike next week to review and provide feedback.

pldespaigne · 2024-05-10T10:51:58Z

That would be awesome 🙏
Anyone's feedback would be great!

Paper.tex

alexprut · 2024-05-22T15:13:13Z

Paper.tex

-&&&& is too low to fulfil the value transfer); and otherwise $x=\mathtt{ADDR}(I_{\mathrm{a}}, \boldsymbol{\sigma}[I_{\mathrm{a}}]_{\mathrm{n}}, \zeta, \mathbf{i} )$, the\\
-&&&& address of the newly created account (\ref{eq:new-address}). \\
+&&&& where $x=0$ if $z = 0$, i.e., the \hyperlink{contract_creation_result}{contract creation process failed},\\
+&&&& or $\lVert \mathbf{i} \rVert > 49152$ (initcode is longer than 49152 bytes),\\


Observation rather than a proposed change: realised that MAX_CODE_SIZE=24576 and 2*24576=49152 is not defined anywhere in the paper, hence the semantic is lost, if there is a section anywhere in the paper then it could go there.

You are right, EIP defines it as it's own constant, but since the YP used the same formalism on post deploy code check (Section 7), I decided to keep it like this.

alexprut · 2024-05-22T15:14:24Z

Soundness of EIP-3860 changes LGTM.

pldespaigne · 2024-05-25T13:39:12Z

Thanks a lot for your feedbacks @alexprut 🙏

pldespaigne · 2024-05-25T14:21:28Z

@nicksavers @pirapira Any time on your side to have a look at this?
Or maybe you could delegate that to someone?

alexprut · 2024-05-27T08:50:12Z

Thanks a lot for your feedbacks @alexprut 🙏

More than happy to be helpful, thanks for updating the YP.
@pldespaigne FYI I still need to look at and review commits EIP-4895, EIP-6049 and General Updates, aiming at finishing the review by EOW.

Paper.tex

alexprut · 2024-05-29T11:57:52Z

Paper.tex

@@ -1365,10 +1404,27 @@ \section{Block Finalisation} \label{ch:finalisation}
 The process of finalising a block involves two stages:


3 stages now

changes in aac8e1c

alexprut · 2024-05-29T12:00:37Z

Paper.tex

@@ -1365,10 +1404,27 @@ \section{Block Finalisation} \label{ch:finalisation}
 The process of finalising a block involves two stages:

 \begin{enumerate}
+\item executing withdrawals;


My understanding is that validate transactions precede executing withdrawals

That's a good question! The EIP only states that it should happen after transaction execution but it says nothing about where it should happen during block finalization.
The transaction validation step purpose in the YP is simply meant to set the block header's gas used value ($B_{Hg}$), since withdrawals incur no gas cost, it has no impact if its run before or after withdrawal execution.

alexprut · 2024-05-29T12:03:16Z

Paper.tex

 \item validate transactions;
 \item verify state.
 \end{enumerate}

+\subsection{Executing Withdrawals}
+After processing the block's transactions, the withdrawals are executed. A withdrawal is simply an increase of the recipient account's balance of the specified amount. No other balances are decreased, a withdrawal is not a transfer but a creation of funds.
+A withdrawal operation cannot fail and has no gas cost. We define the function $P$ as the withdrawal state transition function:


FYI, not necessarily an issue, function P is already defined in the paper.

Good catch! It's actually a big issue here, since $P$ (the parent block function) is used just bellow in the state validation function $\Gamma$, it would be super confusing to call it $P$ as well!

I'll update the withdrawal state transition function as $E$ instead, I believe it's not used in the paper.

changes in aac8e1c

alexprut · 2024-05-29T12:20:34Z

Paper.tex

-\linkdest{selfdestruct}{}0xff & {\small SELFDESTRUCT} & 1 & 0 & Halt execution and register account for later deletion. \\
+\linkdest{selfdestruct}{}0xff & {\small SELFDESTRUCT} & 1 & 0 & Halt execution and register account for later deletion. Readers should be warned, \\
+&&&& since the \textit{Shanghai} update, this opcode has been marked as deprecated. \\
+&&&& Its behavior might be subject to change in an upcoming update. \\


Suggesting adding that it may be subject "to breaking changes"

changes in 22c2ca5

alexprut · 2024-05-29T12:27:38Z

Paper.tex

+Because the Beacon Chain generate a new slot every 12 seconds, post-\textit{Paris} updates can be scheduled to occur at a specific timestamp.
+At the execution layer, the update will then happen in the first produced block after the scheduled timestamp.
+For example the \textit{Shanghai} hard fork was scheduled to occur at 2023-04-12 10:27:35 UTC, on Epoch 194,048.
+Validators failed to propose a block during the two first slots of this Epoch, but at slot 6,209,538 a validator finally proposed a the block 17,034,870, marking the transition to \textit{Shanghai} on the execution layer.


proposed a the block

changes in 878ee5b

alexprut · 2024-05-29T12:30:36Z

Paper.tex

@@ -203,6 +203,7 @@ \subsection{Which History?}
 $F_{\mathrm{Arrow Glacier}}$     & 13773000 \\
 $F_{\mathrm{Gray Glacier}}$      & 15050000 \\
 $F_{\mathrm{Paris}}$             & 15537394 \\
+$F_{\mathrm{Shanghai}}$          & 17034870 \\


Out of scope of this PR, was thinking if going forward there should be another column besides Block Number, e.g. Timestamp or whatever will be the canonical trigger.

That's a good idea imo!

alexprut · 2024-05-29T12:32:15Z

Left small comments, changes for EIP-4895, EIP-6049 and General Updates LGTM.
Assuming that for Shangai Update there are no other EIPs besides the ones listed in https://ethereum.org/en/history/#shanghai-summary

pldespaigne · 2024-06-14T09:23:14Z

Thanks again for your time @alexprut 🙏
I've made all the requested changes and update the PR description.
I'll now try to bring more eyes on this discussion!

@yperbasis how many approvals would be required for you to be comfortable in merging this PR?

yperbasis · 2024-06-14T09:44:31Z

Thanks again for your time @alexprut 🙏 I've made all the requested changes and update the PR description. I'll now try to bring more eyes on this discussion!

@yperbasis how many approvals would be required for you to be comfortable in merging this PR?

Sorry guys, I was on holiday and next week I'll be at a workshop. I'll take a look during the week starting from 24 June.

yperbasis

Please also update BRANCHES.md & README.md (see how it was done in PR #894 for Paris).

yperbasis · 2024-06-26T10:15:31Z

Meanwhile I've created branch paris from the current master.

pldespaigne · 2024-07-01T18:57:57Z

I've rebased the PR with latest changes from master.
I've also updated README.md & BRANCHES.md as requested.

Let me know if I can do anything else!

pldespaigne · 2024-07-08T08:46:38Z

Thanks a lot for your time @yperbasis!
I'll now start to work on the Cancun update, should I open a single PR for the whole update, or do you prefer to review it eip by eip?

yperbasis · 2024-07-08T08:49:08Z

Thanks a lot for your time @yperbasis! I'll now start to work on the Cancun update, should I open a single PR for the whole update, or do you prefer to review it eip by eip?

Thank you! It's easier for me to review eip by eip.

pldespaigne · 2024-07-08T08:55:03Z

Alright, I'll do it eip by eip then!
Also it looks like the merge of this PR didn't triggered a deploy of the new version of the pdf: https://ethereum.github.io/yellowpaper/paper.pdf

alexprut · 2024-07-08T14:57:37Z

Alright, I'll do it eip by eip then! Also it looks like the merge of this PR didn't triggered a deploy of the new version of the pdf: https://ethereum.github.io/yellowpaper/paper.pdf

@pldespaigne If helpful, volunteering on providing feedback for the Cancun PRs, just tag me.

pldespaigne · 2024-07-08T14:59:07Z

Thanks a lot 🙏
Will do, for sure!

yperbasis · 2024-07-17T10:10:39Z

Alright, I'll do it eip by eip then! Also it looks like the merge of this PR didn't triggered a deploy of the new version of the pdf: https://ethereum.github.io/yellowpaper/paper.pdf

I've re-run the job and https://ethereum.github.io/yellowpaper/paper.pdf seems to be fine now.

* eip-3651 * eip-3855 * eip-3860 * eip-4895 * eip-6049 * shanghai * eip-3651-alexprut-review * eip-3860-alexprut-review * eip-4895-alexprut-review * eip-6049-alexprut-review * shanghai-alexprut-review * update README.md & BRANCHES.md

pldespaigne marked this pull request as draft April 30, 2024 17:07

pldespaigne marked this pull request as ready for review April 30, 2024 17:41

pldespaigne changed the title ~~[WIP] Shanghai Update~~ Shanghai Update Apr 30, 2024

alexprut reviewed May 20, 2024

View reviewed changes

Paper.tex Outdated Show resolved Hide resolved

alexprut reviewed May 21, 2024

View reviewed changes

Paper.tex Show resolved Hide resolved

alexprut reviewed May 22, 2024

View reviewed changes

Paper.tex Show resolved Hide resolved

alexprut reviewed May 22, 2024

View reviewed changes

Paper.tex Outdated Show resolved Hide resolved

alexprut reviewed May 22, 2024

View reviewed changes

alexprut reviewed May 29, 2024

View reviewed changes

Paper.tex Show resolved Hide resolved

alexprut reviewed May 29, 2024

View reviewed changes

Paper.tex Show resolved Hide resolved

alexprut reviewed May 29, 2024

View reviewed changes

alexprut approved these changes Jun 7, 2024

View reviewed changes

yperbasis reviewed Jun 26, 2024

View reviewed changes

pldespaigne added 11 commits July 1, 2024 19:19

eip-3651

6fb1032

eip-3855

d997926

eip-3860

8428ca5

eip-4895

5173cdd

eip-6049

20ebaa7

shanghai

5df35cf

eip-3651-alexprut-review

8af40f2

eip-3860-alexprut-review

263171f

eip-4895-alexprut-review

aac8e1c

eip-6049-alexprut-review

22c2ca5

shanghai-alexprut-review

878ee5b

pldespaigne force-pushed the shanghai branch from 2b98d68 to 878ee5b Compare July 1, 2024 17:20

update README.md & BRANCHES.md

67031c9

yperbasis approved these changes Jul 3, 2024

View reviewed changes

yperbasis merged commit 8455623 into ethereum:master Jul 3, 2024
1 check passed

		@@ -1365,10 +1404,27 @@ \section{Block Finalisation} \label{ch:finalisation}
		The process of finalising a block involves two stages:

Shanghai Update #906

Shanghai Update #906

Conversation

pldespaigne commented Apr 30, 2024 • edited Loading

EIP-3651: Warm COINBASE

EIP-3855: PUSH0 instruction

EIP-3860: Limit and meter initcode

EIP-4895: Beacon chain push withdrawals as operations

EIP-6049: Deprecate SELFDESTRUCT

General Updates

pldespaigne commented May 7, 2024

yperbasis commented May 9, 2024

pldespaigne commented May 10, 2024

alexprut commented May 10, 2024 • edited Loading

pldespaigne commented May 10, 2024

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexprut commented May 22, 2024

pldespaigne commented May 25, 2024

pldespaigne commented May 25, 2024

alexprut commented May 27, 2024

Choose a reason for hiding this comment

pldespaigne Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pldespaigne Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pldespaigne Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

pldespaigne Jun 14, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

alexprut commented May 29, 2024

pldespaigne commented Jun 14, 2024

yperbasis commented Jun 14, 2024

yperbasis left a comment

Choose a reason for hiding this comment

yperbasis commented Jun 26, 2024

pldespaigne commented Jul 1, 2024

pldespaigne commented Jul 8, 2024

yperbasis commented Jul 8, 2024

pldespaigne commented Jul 8, 2024

alexprut commented Jul 8, 2024

pldespaigne commented Jul 8, 2024

yperbasis commented Jul 17, 2024

pldespaigne commented Apr 30, 2024 •

edited

Loading

alexprut commented May 10, 2024 •

edited

Loading

pldespaigne Jun 14, 2024 •

edited

Loading

pldespaigne Jun 14, 2024 •

edited

Loading

pldespaigne Jun 14, 2024 •

edited

Loading

pldespaigne Jun 14, 2024 •

edited

Loading