chore: pin crunchy for Windows compatibility #1670
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Still working on testing it locally |
Shouldn't you push the updated lock file as well? |
|
Yeah, I will before taking it out of Draft. But I'm finding that it locally is still allowing crunchy to go to 0.2.3 |
|
KolbyML
approved these changes
Feb 6, 2025
PR overall looks good, of course pushing the updated lock files which uses the patch is required for CI to pass
Cargo.toml
Outdated
| # get the wrong path, update this when the workflow has been updated | ||
| # | ||
| # See: https://github.com/eira-fransham/crunchy/issues/13 | ||
| crunchy = { git = "https://github.com/eira-fransham/crunchy", ref = "1bf90cf2d0a8cfcb2c5592275a23ab028dff6468" } |
There was a problem hiding this comment.
Suggested change
| crunchy = { git = "https://github.com/eira-fransham/crunchy", ref = "1bf90cf2d0a8cfcb2c5592275a23ab028dff6468" } | |
| crunchy = { git = "https://github.com/eira-fransham/crunchy", rev = "1bf90cf2d0a8cfcb2c5592275a23ab028dff6468" } |
this must be rev instead of ref
|
Weird that the tooling didn't complain about ref. It's maybe the only time that Rust tooling has been too relaxed for my taste. X) |
Need the patch for all the sub-dependencies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What was wrong?
Windows build is failing: https://github.com/ethereum/trin/actions/runs/13189513029/job/36819458339
How was it fixed?
Pin crunchy for all dependencies