chore: update depends so we can use sigp crates directly #1423
Conversation
KolbyML
requested review from
carver,
mrferris,
njgheorghita,
ogenev and
morph-dev
KolbyML
force-pushed
the
update-to-alloy
branch
from
68f4bae to
70bbe46
Compare
| gas_used, | ||
| timestamp: U256::from(timestamp), | ||
| number, | ||
| gas_limit: gas_limit.to::<u128>(), |
There was a problem hiding this comment.
nit: I didn't check it, but I think you don't have to specify ::<u128> as compiler should be able to figure it out. But it's fine if you want to be explicit. Here and in most other places
Cargo.toml
Outdated
| @@ -80,8 +80,8 @@ members = [ | |||
|
|
|||
| [workspace.dependencies] | |||
| alloy-consensus = { git = "https://github.com/alloy-rs/alloy.git", rev = "d68a6b787b2904061f0ae7fcc02ece8513e3c500"} | |||
There was a problem hiding this comment.
Can we update this as well?
There was a problem hiding this comment.
I will just remove it as we just use a constant from it so it is a little overkill
There was a problem hiding this comment.
nit: You could have used alloy_consensus: v0.3.1, as we already depend on it indirectly. Up to you.
I tried, but they have it configured weird so it wasn't easy to do |
I think I figured it out |
|
@morph-dev ready for another review I believe I resolved all the concerns |
trin-execution/Cargo.toml
Outdated
| @@ -12,6 +12,7 @@ authors = ["https://github.com/ethereum/trin/graphs/contributors"] | |||
|
|
|||
|
|
|||
| [dependencies] | |||
| alloy-consensus.workspace = true | |||
There was a problem hiding this comment.
nit: just don't forget to remove constants that you introduced
What was wrong?
This is a part of 68f4bae
We were relying on forks of sigp library's during our transition to using Reth's primitive types, I made forks to update those sigp libraries to use Reth's primitives as well, they are now updated so here is a PR using them
How was it fixed?
Updating library's as required and code as well.
Many libraries depend on each other in certain ways so I just updated everything that be needed so we can compile again, well also achieving the goal of relying on sigp's library's directly again