Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(beacon-network): add json-rpc method to get the latest finalized state root #1364

Merged
merged 1 commit into from
Aug 9, 2024

Conversation

ogenev
Copy link
Member

@ogenev ogenev commented Aug 8, 2024

What was wrong?

To be able to validate HistoricalSummariesWithProof, we want to access the latest finalized beacon state root from the light client module.

The current design in HeaderOracle relies on JSON-RPC requests for accessing the data from the overlay networks.

This endpoint is required for fixing #1323.

Here is a PR to add the endpoint to beacon json-rpc specs as it will be useful for hive testing.

How was it fixed?

  • implement portal_beaconFinalizedStateRoot json-rpc endpoint.

This endpoint was tested locally with beacon synced node.

To-Do

@ogenev ogenev self-assigned this Aug 8, 2024
@ogenev ogenev added the beacon network Issue related to portal beacon network label Aug 8, 2024
@ogenev ogenev marked this pull request as ready for review August 8, 2024 08:51
@ogenev ogenev requested review from njgheorghita and KolbyML August 8, 2024 08:52
Copy link
Member

@KolbyML KolbyML left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@ogenev ogenev merged commit 193e29b into ethereum:master Aug 9, 2024
8 checks passed
@ogenev ogenev deleted the finalized-state-root-api branch August 9, 2024 07:19
ogenev added a commit to ogenev/trin that referenced this pull request Aug 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
beacon network Issue related to portal beacon network
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants