Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing cli version checker #714

Open
wants to merge 1 commit into
base: dev
Choose a base branch
from

Conversation

valefar-on-discord
Copy link
Contributor

When generating a deposit with the staking-deposit-cli, the resulting deposit file will contain a cli version: deposit_cli_version. The launchpad currently verifies this value is above a certain threshold defined in the env file, 2.7.0.

There are two problems:

  • If this check fails, the resulting error presented to the user says there is a problem with the network
  • This makes it difficult for multiple tools to exist

To get around these two issues, this PR removes the version check entirely.

As a side effect, compare-version is no longer a direct dependency as this was the only location where it it is used but it is still a dependency of husky

Copy link

netlify bot commented Oct 26, 2024

👷 Deploy request for dapper-rolypoly-9814ad pending review.

Visit the deploys page to approve it

Name Link
🔨 Latest commit 40612f9

@valefar-on-discord
Copy link
Contributor Author

@wackerow Here is the PR as promised.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant