Skip to content

Inventory of removed error codes to prevent reuse #16003

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

vlad-khramov
Copy link
Contributor

@vlad-khramov vlad-khramov commented Apr 12, 2025

Closes #13545

  • added REMOVED_IDS set in the error_codes.py
  • found all previosly removed error codes and added to this set (with references to the files and removal commits)
    • These error codes were already reused {'5883', '2314', '9239', '9609', '2450', '6546', '4316', '5798', '3881', '2657'}
  • CI job chk_errorcodes was modified, added check that all removed errors in the current PR were added to the REMOVED_IDS

Copy link

Thank you for your contribution to the Solidity compiler! A team member will follow up shortly.

If you haven't read our contributing guidelines and our review checklist before, please do it now, this makes the reviewing process and accepting your contribution smoother.

If you have any questions or need our help, feel free to post them in the PR or talk to us directly on the #solidity-dev channel on Matrix.

@vlad-khramov vlad-khramov force-pushed the check_removed_errors branch 4 times, most recently from 9fe0a32 to 0019e22 Compare April 12, 2025 13:51
@vlad-khramov vlad-khramov changed the title [wip] Inventory of removed error codes to prevent reuse Inventory of removed error codes to prevent reuse Apr 12, 2025
@vlad-khramov
Copy link
Contributor Author

Not sure why ci/circleci: b_osx is failing, my changes shoudn't affect it

@clonker
Copy link
Member

clonker commented Apr 14, 2025

Yeah it's unrelated! We have issues with osx builds and our pedantic compiler settings. For some reason, boost will generate warnings despite being system library on macos with cmake 4.0.0. We switched the settings to less pedantic ones for a particular appleclang version but since that got bumped by CI, you're seeing these failures.

@clonker clonker force-pushed the check_removed_errors branch from 0019e22 to 9fe6580 Compare April 14, 2025 09:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Check for reuse of old error/warning codes
2 participants