Report errors only for contracts that directly inherit from one with a specified storage layout #15900
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
matheusaaguiar
changed the title
9 tasks
1 task
cameel
requested changes
Feb 28, 2025
matheusaaguiar
force-pushed
the
fixStorageLayoutSpecifierErrorMsg
branch
2 times, most recently
from
6204a59 to
22c333d
Compare
cameel
reviewed
Mar 1, 2025
There was a problem hiding this comment.
Looks correct now, but you need to update expectations in command-line tests.
Also, your commits are a bit misleading because "Add tests" actually mostly updates existing tests. The commit is also at the top - if you want to keep it separate, it would be much more useful to put it first so that we can see what the test output was initially. Then to see in subsequent commits how they affected those tests.
matheusaaguiar
force-pushed
the
fixStorageLayoutSpecifierErrorMsg
branch
from
0aec6d0 to
ecb0dce
Compare
cameel
force-pushed
the
fixStorageLayoutSpecifierErrorMsg
branch
from
ecb0dce to
2995f04
Compare
cameel
approved these changes
Mar 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Suggested in #15528 (comment)